1000359 - Assertion failure: "Should only make struts for children with 'visibility:collapse'" with flexbox

Status: RESOLVED DUPLICATE of bug 1639053

(Core :: Layout, defect)

Description

[Jesse Ruderman]

Attachment: testcase

Assertion failure: 2 == mFrame->StyleVisibility()->mVisible (Should only make struts for children with 'visibility:collapse'), at layout/generic/nsFlexContainerFrame.cpp:1220

Comment 1

[Jesse Ruderman]

Attachment: stack

Comment 2

[Daniel Holbert [:dholbert]]

I can reproduce this in my Linux debug build.

Marking as depending on bug 783470, which added the "visibility:collapse" behavior for flexbox.

Comment 3

[Daniel Holbert [:dholbert]]

Yeah, this is a regression from bug 983427.

We build the strut-list by walking over our flex lines & their flex items, which may be in reverse order with respect to the frame list. (after bug 983427)  So the strut indexes may be indexes with respect to the *end* of our child list (walking in reverse). But when we use them, in GenerateFlexLines, we treat them as if they're indexes from the start.

Comment 4

[Jesse Ruderman]

Attachment: less weird testcase

Comment 5

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Bug 1639053 removed the ability to reverse flex container's axes internally, so the testcases can no longer trigger assertions.