Closed Bug 1000377 Opened 6 years ago Closed 6 years ago

Always show the toggleable toolbars dropdown in customization mode even if the only toolbar available is the bookmarks toolbar

Categories

(Firefox :: Toolbars and Customization, defect)

All
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 31

People

(Reporter: jaws, Assigned: jaws)

References

Details

Attachments

(1 file)

This is in opposition to https://bugzilla.mozilla.org/show_bug.cgi?id=940669#c30.

<jaws> why don't we show the Bookmarks Toolbar as a toggle-able option in the Customize mode on OSX?
— jaws reads through bug 940669
<shorlander> jaws: only appears when you have more than one toolbar available. Not sure what the rationale was.
<jaws> shorlander: yeah it doesn't make sense to me
<jaws> shorlander: on windows you can use this to show the bookmarks toolbar. on mac this is non existant
<jaws> we don't provide the same path for users on osx and windows. that doesn't seem right
<madhava> I think it's only there if you have at least one toolbar other than the bookmarks bar
<madhava> i.e. toolbars for which there's no other switch
<madhava> which is, yes, odd
<madhava> so, windows uses with the menubar shown will have it
<madhava> anyone with an add-on toolbar will have it
<madhava> I think we should have an Australis 1.1 bug
<madhava> to just always show it
Flags: firefox-backlog?
Attached patch PatchSplinter Review
Attachment #8411238 - Flags: review?(MattN+bmo)
Comment on attachment 8411238 [details] [diff] [review]
Patch

Thanks, this came up in the screenshots too. I'll dupe the older bug here.
Attachment #8411238 - Flags: review?(MattN+bmo) → review+
https://hg.mozilla.org/mozilla-central/rev/63bb9295a070
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 31
Flags: firefox-backlog? → firefox-backlog+
Flags: in-testsuite?
You need to log in before you can comment on or make changes to this bug.