Add automated test for showing the toolbars dropdown in customization mode (even if the only toolbar available is the bookmarks toolbar)

RESOLVED FIXED in Firefox 35

Status

()

Firefox
Toolbars and Customization
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: mihaelav, Assigned: mihaelav)

Tracking

Trunk
Firefox 35
Points:
---
Bug Flags:
qe-verify -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

4 years ago
Automated test for bug 1000377:

Add automated test for to check that the toggleable toolbars dropdown is shown in customization mode even if the only toolbar available is the bookmarks toolbar
(Assignee)

Comment 1

4 years ago
Created attachment 8480386 [details] [diff] [review]
v1

Test for bug1000377.
Attachment #8480386 - Flags: review?(jaws)
Comment on attachment 8480386 [details] [diff] [review]
v1

Review of attachment 8480386 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/components/customizableui/test/browser_1058573_showToolbarsDropdown.js
@@ +14,5 @@
> +  yield removeCustomToolbars();
> +
> +  tab = gBrowser.selectedTab;
> +  yield promiseTabLoadEvent(tab, "about:customizing");
> +  info("about:customizing was opened");

You can replace these three lines with:
yield startCustomizing();

@@ +25,5 @@
> +
> +add_task(function asyncCleanup() {
> +  // restore the initial location
> +  gBrowser.addTab(initialLocation);
> +  gBrowser.removeTab(tab);

These can be replaced with:
yield endCusotmizing();

which will make the `let tab = null; let initialLocation = gBrowser.currentURI.spec;` at the top of this file unneeded.
Attachment #8480386 - Flags: review?(jaws) → feedback+
(Assignee)

Comment 3

4 years ago
Created attachment 8480430 [details] [diff] [review]
v2

Updated based on review
Attachment #8480386 - Attachment is obsolete: true
Attachment #8480430 - Flags: review?(jaws)
Attachment #8480430 - Flags: review?(jaws) → review+
(Assignee)

Comment 4

4 years ago
Thanks Jared.
Keywords: checkin-needed
https://hg.mozilla.org/integration/fx-team/rev/7c28c12de7aa
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]

Comment 6

4 years ago
https://hg.mozilla.org/mozilla-central/rev/7c28c12de7aa
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 35
Flags: qe-verify-
You need to log in before you can comment on or make changes to this bug.