1000434 - Thimble won't render preview with custom elements in document

Status: RESOLVED FIXED

(Webmaker Graveyard :: Thimble, defect)

Description

[Bobby Richter [:secretrobotron]]

Thimble doesn't allow preview to render when there is an element with an unrecognized tag, e.g. <foo-bar>.

Can we allow tags with dashes in their names (as per the Web Components specs)?

e.g. https://thimble.webmaker.org/en-US/project/49428/edit

Hilariously, another bug I filed about incomplete tags disallowed this by preventing preview when errors are detected: https://bugzilla.mozilla.org/show_bug.cgi?id=985971

Can the "this tag is unrecognized" error be an warning instead for tags with dashes in them? Or (better still), nothing?

Comment 1

[Bobby Richter [:secretrobotron]]

Attachment: https://github.com/mozilla/thimble.webmaker.org/pull/420

Comment 2

[Pomax]

Comment on attachment 8412062 [details] [review]
https://github.com/mozilla/thimble.webmaker.org/pull/420

few nits left

Comment 3

[Bobby Richter [:secretrobotron]]

Excellent. Moved custom-element.html content to a gist because it shouldn't be in the tree: https://gist.github.com/secretrobotron/846d28209f9e9bc83e7f

Comment 4

[Pomax]

Comment on attachment 8412062 [details] [review]
https://github.com/mozilla/thimble.webmaker.org/pull/420

sweet deal. Squash before merging in and we're a step closer to winning.

Comment 5

[Bobby Richter [:secretrobotron]]

Squashed. Merge?

Comment 6

[Pomax]

merged. Give thimble.mofostaging.net a whirl and if it holds up, let's push to production.