1000454 - [B2G][1.4][Gaia]: The timestamp for a file downloaded a week ago is missing on all languages

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[KTucker [:KTucker][Inactive 3/4/2016]]

Attachment: missing timestamp.png

Description:
The timestamp for a file downloaded a week ago is missing on all languages.

Repro Steps:
1) Update a Buri to BuildID: 20140421000201 
2) Go to http://goo.gl/mDx5Bh
3) Download a file. 
4) After the file has completed downloaded, tap on the "Settings" app. 
5) Change the date of the device to exactly 7 days ahead.
6) Tap on "downloads" and check the timestamp of when the file downloaded. 

Actual:
Files downloaded 7 days ago will be missing their timestamp under "Downloads" in Settings. 

Expected:
Files downloaded 7 days ago have the correct timestamp. 

1.4 Environmental Variables:
Device: Buri 1.4 MOZ
BuildID: 20140421000201
Gaia: 3c53bebcc7541e5d19c96cf38ee2603927478f3c
Gecko: 97dfbd4530a0
Version: 30.0a2
Firmware Version: v1.2-device.cfg

Repro frequency: 100%
See attached: screenshot

Comment 1

[KTucker [:KTucker][Inactive 3/4/2016]]

This issue does not occur on the Buri 1.3 Moz RIL 

1.3 Environmental Variables:
Device: Buri 1.3 MOZ
BuildID: 20140422024003
Gaia: cab7de82832d00696807ae48ec277bd642b82a0a
Gecko: c35695cc384c
Version: 28.0
Firmware Version: v1.2-device.cfg

There is not a "Downloads" section in settings on v 1.3

Comment 2

[KTucker [:KTucker][Inactive 3/4/2016]]

Attachment: Timestamplog.txt

Comment 3

[Francesco Lodolo [:flod]]

Basically you're trying to localize a non existent string: weeks-ago-short
https://github.com/mozilla-b2g/gaia/blob/master/shared/js/download/download_formatter.js#L77

CCing the two person who worked on this file.

The quick solution is to switch to long formats, and I think it wouldn't be a problem considering the amount of space available in that screen.

Comment 4

[Cristian Rodriguez (:crdlc)]

Attachment: Patch v1

It works fine and I agree with you, we have almost all the screen to paint this

Comment 5

[Francesco Lodolo [:flod]]

Comment on attachment 8411727 [details]
Patch v1

Looks good to me, but you need a real reviewer ;-)

I also think we need to set the 1.4? flag

Comment 6

[Jason Smith [:jsmith]]

If you change the timezone of the device instead of the date, does this bug reproduce?

Comment 7

[Francesco Lodolo [:flod]]

Jason, issue is not related to changing the date, in this case it's used to reproduce.

If you have a file downloaded more than 7 days ago, but less than 10, you will see nothing as the date.

Comment 8

[Pi Wei Cheng [:piwei] (inactive)]

(In reply to Jason Smith [:jsmith] from comment #6)
> If you change the timezone of the device instead of the date, does this bug
> reproduce?

Changing timezones does not seem to have any effect on the download time - I changed to Anadyr, Russia (UTC+12), and the download time still displays as XX minutes ago after reboot of phone. Same thing occurs when I changed timezone to Honolulu (UTC -10).

Tested on:
Device: Buri 1.4 MOZ
BuildID: 20140424000203
Gaia: b6a41ee9e2934fe9692da6fb1cb310cb759e9870
Gecko: 2e9abf89c087
Version: 30.0a2
Firmware Version: v1.2-device.cfg

Comment 9

[Cristian Rodriguez (:crdlc)]

https://github.com/mozilla-b2g/gaia/commit/d4d02d281361930a4e5d480d6ec664886a565080

Comment 10

[Ryan VanderMeulen [:RyanVM]]

v1.4: https://github.com/mozilla-b2g/gaia/commit/01b7794397834bc7c350c3edcf81742a1b393bfb

Comment 11

[Mike Livingston]

This issue has been fixed on the Buri 1.4 MOZ RIL

1.4 Environmental Variables:
Device: Buri 1.4 MOZ
BuildID: 20140508000201
Gaia: 4ce973ef0732b0d52cb043210db598aa176b2ce9
Gecko: 16ab7f6b18f8
Version: 30.0
Firmware Version: v1.2-device.cfg