1000523 - [B2G][Open_C]When in a phone call, the proximity sensor does not turn off the screen

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Andrew Stole [:astole]]

Attachment: logcat

When in a phone call, the proximity sensor doesn't activate and the screen stays on even when the phone is held up to the user's ear

Repro Steps:
1) Update a Open_C to BuildID: 20140423040203
2) Open the dialer app
3) Make a phone call and cover the proximity sensor

Actual:
The proximity sensor does not disable the screen

Expected:
The proximity sensor should disable the screen

2.0 Environmental Variables:
Device: Open_C 2.0
BuildID: 20140423040203
Gaia: d8904c5af6152f5d647a93a0c31227171ddecd87
Gecko: ac376a4e8174
Version: 31.0a1
Firmware Version: P821A10-ENG_20140410

Repro frequency: 3/3, 100%
See attached: logcat, video

Comment 1

[Jason Smith [:jsmith]]

Does this happen on a 1.3 Open C base image?

Comment 2

[jongsoo.oh]

I checked this issue.
This issue is reproduced in master and v1.3 branch

Comment 3

[jongsoo.oh]

reproduction steps:

Step 1: User dials a number -> Proximity sensor is not working
Step 2: User presses Send -> Proximity sensor is not working
Step 3: Phone is trying to connect the call -> Proximity sensor is not working
Step 4: Call is connected -> Proximity sensor starts working

If the user put the phone in his/her face before Step 4, the screen is not turn off.

Comment 4

[Wayne Chang [:wchang]]

The p-sensor seems to only start 'detect change' after the call has been connected.

So if the p-sensor is covered before the call is connected, even after it is connected the screen stays on and may lead to unwanted input.

Comment 5

[Mozilla Shepherd (This account is used for automation and doesn't receive bugmail)]

Attachment: mozilla-b2g:master PR#18633

Comment 6

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8411694 [details] [review]
mozilla-b2g:master PR#18633

According to Hsinyi, the step 2 described above should be "dialing".

Including that in the list of |statechange| event handling should solve the issue when the user put the phone near their face before the phone is "alerting" (when the ringing tone is heard).

Note that we are given a |userproximity| event in Gaia but not a DOM property, so will not be able to detect user's face any time before "dialing" (i.e. before user hitting the green button). If we want to keep the sensor on on all times it will drain the battery.

We should consider simplifying screen_manager.js and move the logic to somewhere like call screen, if possible.

Comment 7

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 8411694 [details] [review]
mozilla-b2g:master PR#18633

Looks good to me.

Comment 9

[Tim Guan-tin Chien [:timdream] (please needinfo)]

master: https://github.com/mozilla-b2g/gaia/commit/8d46a6063b9d5b986f56ccf51b3eac12f034d5a7

Comment 10

[GitHub Autolander Bot]

Attachment: [gaia] etiennesegonzac:bug-1000523 > mozilla-b2g:master