Closed
Bug 1000608
Opened 10 years ago
Closed 10 years ago
Implement seeking portion of Media Source Extensions spec
Categories
(Core :: Audio/Video, defect)
Core
Audio/Video
Tracking
()
RESOLVED
FIXED
mozilla31
People
(Reporter: cajbir, Assigned: cajbir)
References
(Blocks 2 open bugs, )
Details
Attachments
(5 files, 5 obsolete files)
3.69 KB,
patch
|
kinetik
:
review+
|
Details | Diff | Splinter Review |
3.70 KB,
patch
|
cajbir
:
review+
|
Details | Diff | Splinter Review |
5.25 KB,
patch
|
cajbir
:
review+
|
Details | Diff | Splinter Review |
3.58 KB,
patch
|
cajbir
:
review+
|
Details | Diff | Splinter Review |
2.01 KB,
patch
|
kinetik
:
review+
|
Details | Diff | Splinter Review |
For seeking to work in web apps that use MSE we need to implement: http://www.w3.org/TR/media-source/#mediasource-seeking This is required to get seeking working on the YouTube MSE player.
Assignee | ||
Comment 1•10 years ago
|
||
This is a patch to libnestegg to allow operations after a seek to a raw offset to work. Asking for feedback to see if this is an ok approach and will do a github pull request when/if f+.
Assignee: nobody → cajbir.bugzilla
Status: NEW → ASSIGNED
Attachment #8411470 -
Flags: feedback?(kinetik)
Assignee | ||
Comment 2•10 years ago
|
||
Attachment #8411471 -
Flags: review?(kinetik)
Assignee | ||
Comment 3•10 years ago
|
||
Attachment #8411472 -
Flags: review?(kinetik)
Assignee | ||
Comment 4•10 years ago
|
||
If seeking fails in the WebM reader, fall back to trying a seek using the internal offset data we keep track of. This handles MSE WebM files that don't have cues.
Attachment #8411475 -
Flags: review?(kinetik)
Assignee | ||
Comment 5•10 years ago
|
||
With these four patches applied seeking works on http://cd.pn/mse/ytdemo/dash-player.html?url=http://cd.pn/mse/ytdemo/feelings2.mpd. Patches to come for the "If one or more of the objects in activeSourceBuffers is missing media segments for the new playback position" part of the spec.
Updated•10 years ago
|
Attachment #8411471 -
Flags: review?(kinetik) → review+
Updated•10 years ago
|
Attachment #8411472 -
Flags: review?(kinetik) → review+
Comment 6•10 years ago
|
||
Comment on attachment 8411470 [details] [diff] [review] p1: nestegg change ctx->log(ctx, NESTEGG_LOG_DEBUG, "seek: parsing cluster elements"); Move this line with the ne_parse call into offset_seek. Otherwise, looks good.
Attachment #8411470 -
Flags: feedback?(kinetik) → feedback+
Updated•10 years ago
|
Attachment #8411475 -
Flags: review?(kinetik) → review+
Assignee | ||
Comment 7•10 years ago
|
||
Attachment #8411496 -
Flags: review?(kinetik)
Comment 8•10 years ago
|
||
Comment on attachment 8411496 [details] [diff] [review] p5: Populate active source buffers and fix ContainsTime for (uint32_t i = 0; i < mSourceBuffers.Length(); ++i) { if (!mSourceBuffers[i]->ContainsTime(aTime)) { return false; } } - return true; + return mSourceBuffers.Length() > 0; I think this should be: for (uint32_t i = 0; i < mSourceBuffers.Length(); ++i) { if (mSourceBuffers[i]->ContainsTime(aTime)) { return true; } } return false;
Assignee | ||
Comment 9•10 years ago
|
||
I've renamed ContainsTime to AllContainsTime on SourceBufferList to make it clearer as to what it does.
Attachment #8411496 -
Attachment is obsolete: true
Attachment #8411496 -
Flags: review?(kinetik)
Attachment #8411510 -
Flags: review?(kinetik)
Assignee | ||
Comment 10•10 years ago
|
||
Rebased on top of latest bug 881512 code. Carrying r+ forward.
Attachment #8411471 -
Attachment is obsolete: true
Attachment #8411511 -
Flags: review+
Assignee | ||
Comment 11•10 years ago
|
||
Rebased on top of latest bug 881512 code. Carrying r+ forward.
Attachment #8411472 -
Attachment is obsolete: true
Attachment #8411512 -
Flags: review+
Assignee | ||
Comment 12•10 years ago
|
||
Rebased on top of latest bug 881512 code. Carrying r+ forward.
Attachment #8411475 -
Attachment is obsolete: true
Attachment #8411513 -
Flags: review+
Updated•10 years ago
|
Attachment #8411510 -
Flags: review?(kinetik) → review+
Assignee | ||
Comment 13•10 years ago
|
||
Updates to latest libnestegg code which contains pull request 20 (https://github.com/kinetiknz/nestegg/pull/20). That pull request contains the attachment 8411470 [details] [diff] [review] fix plus review comments.
Attachment #8411470 -
Attachment is obsolete: true
Attachment #8411515 -
Flags: review?(kinetik)
Updated•10 years ago
|
Attachment #8411515 -
Flags: review?(kinetik) → review+
Comment 14•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?changeset=d75260ca4ed2 d75260ca4ed2 cajbir — Bug 1000608 - Populate active source buffers and fix/rename ContainsTime - r=kinetik default tip f398aa51c65a cajbir — Bug 1000608 - Implement cue-less seeking on WebM Reader - r=kinetik a336e673aaf5 cajbir — Bug 1000608 - Implement seeking on MediaSourceDecoder - r=kinetik 1e21f55bcc9d cajbir — Bug 1000608 - Allow querying source buffers to see if they contain data for a given time - r=kinetik 826e982173dd cajbir — Bug 1000608 - Allow nestegg_offset_seek to be called externally - r=kinetik
Comment 15•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/826e982173dd https://hg.mozilla.org/mozilla-central/rev/1e21f55bcc9d https://hg.mozilla.org/mozilla-central/rev/a336e673aaf5 https://hg.mozilla.org/mozilla-central/rev/f398aa51c65a https://hg.mozilla.org/mozilla-central/rev/d75260ca4ed2
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
You need to log in
before you can comment on or make changes to this bug.
Description
•