Closed Bug 1000618 Opened 8 years ago Closed 8 years ago

Awesome bar suggestions don't work with AIType keyboard

Categories

(Firefox for Android Graveyard :: Keyboards and IME, defect)

29 Branch
x86_64
Android
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 32

People

(Reporter: ahochberg, Assigned: jchen)

Details

Attachments

(1 file)

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:29.0) Gecko/20100101 Firefox/29.0 (Beta/Release)
Build ID: 20140421221237

Steps to reproduce:

When I use AItype as the keyboard on my device, the suggestions on the Awesome Bar don't work right. When I begin typing a word, for example, "Radio," Firefox correctly displays a list of suggested sites from my history that contain that word.  However, when I tap on one of the suggestions, instead of going to that site, it simply repeats the word in the Awesome Bar:  "radioradio"


Actual results:

Tapping a suggested site from the Awesome Screen makes the search phrase display twice in the Awesome Bar. This only occurs with AItype as the keyboard. The Android default keyboard does not display this behavior.


Expected results:

Tapping on the suggested site should load the site.
OS: Windows 7 → Android
On LG Nexus 4 (Android 4.4.2) if I type on the search suggestions I am redirected to that site.
Can you please tell me what device and OS do you have?
And can you reproduce using Firefox Nightly for Android (http://nightly.mozilla.org/)?
Flags: needinfo?(ahochberg)
Yes, the same thing occurs with the Nightlys. If I type, for instance, "face" in the awesome bar, Firefox properly suggests www.facebook.com.  But when I tap on the suggestion, instead of taking me to Facebook, the word "faceface" appears in the bar. 

The device is a Motorola Photon running Android 2.3 and AItype Keyboard Plus 2.1.0.4.
Flags: needinfo?(ahochberg)
Component: Awesomescreen → Keyboards and IME
Related to bug 990314?
Flags: needinfo?(nchen)
I could reproduce on my 2.2 device, and unfortunately the new autocomplete code doesn't seem to fix it :(
Status: UNCONFIRMED → NEW
Ever confirmed: true
Flags: needinfo?(nchen)
Thanks. I've noticed that on some occasions, Firefox eventually will load the proper site.  So if I type "face" in the awesome bar and tap the "Facebook" suggestion, it will display "faceface" in the bar, but still eventually load www.facebook.com.  On other occasions, though it will display "faceface" in the bar, then crash.
I'm inclined to think it's a bug in AIType, but this patch seems to work around the problem.
Attachment #8422805 - Flags: review?(lucasr.at.mozilla)
Comment on attachment 8422805 [details] [diff] [review]
Restart input after hiding it during blur (v1)

Review of attachment 8422805 [details] [diff] [review]:
-----------------------------------------------------------------

As long as it doesn't cause any regressions :-)
Attachment #8422805 - Flags: review?(lucasr.at.mozilla) → review+
Assignee: nobody → nchen
Status: NEW → ASSIGNED
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/954529d300c6
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 32
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.