1000618 - Awesome bar suggestions don't work with AIType keyboard

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Keyboards and IME, defect)

Description

[Adam Hochberg]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:29.0) Gecko/20100101 Firefox/29.0 (Beta/Release)
Build ID: 20140421221237

Steps to reproduce:

When I use AItype as the keyboard on my device, the suggestions on the Awesome Bar don't work right. When I begin typing a word, for example, "Radio," Firefox correctly displays a list of suggested sites from my history that contain that word.  However, when I tap on one of the suggestions, instead of going to that site, it simply repeats the word in the Awesome Bar:  "radioradio"


Actual results:

Tapping a suggested site from the Awesome Screen makes the search phrase display twice in the Awesome Bar. This only occurs with AItype as the keyboard. The Android default keyboard does not display this behavior.


Expected results:

Tapping on the suggested site should load the site.

Comment 1

[Teodora Vermesan (:TeoVermesan)]

On LG Nexus 4 (Android 4.4.2) if I type on the search suggestions I am redirected to that site.
Can you please tell me what device and OS do you have?
And can you reproduce using Firefox Nightly for Android (http://nightly.mozilla.org/)?

Comment 2

[Adam Hochberg]

Yes, the same thing occurs with the Nightlys. If I type, for instance, "face" in the awesome bar, Firefox properly suggests www.facebook.com.  But when I tap on the suggestion, instead of taking me to Facebook, the word "faceface" appears in the bar. 

The device is a Motorola Photon running Android 2.3 and AItype Keyboard Plus 2.1.0.4.

Comment 3

[Aaron Train [:aaronmt]]

Related to bug 990314?

Comment 4

[(inactive) Jim Chen [:jchen] [:darchons]]

I could reproduce on my 2.2 device, and unfortunately the new autocomplete code doesn't seem to fix it :(

Comment 5

[Adam Hochberg]

Thanks. I've noticed that on some occasions, Firefox eventually will load the proper site.  So if I type "face" in the awesome bar and tap the "Facebook" suggestion, it will display "faceface" in the bar, but still eventually load www.facebook.com.  On other occasions, though it will display "faceface" in the bar, then crash.

Comment 6

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Restart input after hiding it during blur (v1)

I'm inclined to think it's a bug in AIType, but this patch seems to work around the problem.

Comment 7

[Lucas Rocha (:lucasr)]

Comment on attachment 8422805 [details] [diff] [review]
Restart input after hiding it during blur (v1)

Review of attachment 8422805 [details] [diff] [review]:
-----------------------------------------------------------------

As long as it doesn't cause any regressions :-)

Comment 8

[(inactive) Jim Chen [:jchen] [:darchons]]

Try: https://tbpl.mozilla.org/?tree=Try&rev=e547d6899a40

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/fx-team/rev/954529d300c6

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/954529d300c6