1000736 - Throw a not supported error if an app tries to record a video from a video file being transcoded into a stream

Status: RESOLVED FIXED

(Core :: Audio/Video: Recording, defect)

Description

[Jason Smith [:jsmith]]

1.4 wasn't intending to support video recording for transcoded video files, but it's currently exposed to the web. This is potentially bad for a few reasons:

1. Poor developer experience - a developer could think that the feature works, as some parts of video recording work here, but others do not.
2. Unintentional user side effects - a user gets negatively impacted from an app using an unsupported API with an unexpected side effect (e.g. crash)

As such, we should throw a not supported error if someone tries to record a video using a transcoded file to avoid getting into this situation in the first place.

Reference Bug List:

* https://bugzilla.mozilla.org/show_bug.cgi?id=997593
* https://bugzilla.mozilla.org/show_bug.cgi?id=999891
* https://bugzilla.mozilla.org/show_bug.cgi?id=999894
* https://bugzilla.mozilla.org/show_bug.cgi?id=999896
* https://bugzilla.mozilla.org/show_bug.cgi?id=999897
* https://bugzilla.mozilla.org/show_bug.cgi?id=999900
* https://bugzilla.mozilla.org/show_bug.cgi?id=999901
* https://bugzilla.mozilla.org/show_bug.cgi?id=999904
* https://bugzilla.mozilla.org/show_bug.cgi?id=999906
* https://bugzilla.mozilla.org/show_bug.cgi?id=999909
* https://bugzilla.mozilla.org/show_bug.cgi?id=999912

Comment 1

[Randy Lin [:rlin] - Be Mozillian on 2015/01/26]

Hi Roc, 
Do you know how can I distinguish the media stream come from video tag or mozCamera?

Comment 2

[Randy Lin [:rlin] - Be Mozillian on 2015/01/26]

ni roc.

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

What's actually causing the problems? Unexpected frame sizes or frame rates? If so we should simply check for the frame sizes and rates we want to support from the camera and reject everything else. I think we should do that instead of trying to detect transcoding specifically.

Comment 4

[Randy Lin [:rlin] - Be Mozillian on 2015/01/26]

The encoder receive a new color format from omx decoder: OMX_QCOM_COLOR_FormatYUV420PackedSemiPlanar32m = 0x7FA30C04, the OMXWrapper need to handle this.

Comment 5

[Randy Lin [:rlin] - Be Mozillian on 2015/01/26]

Attachment: patch v1

Check if the frame size is different with the gUM frame size and throw error.
Also add check for the color format.

Comment 6

[Randy Lin [:rlin] - Be Mozillian on 2015/01/26]

Comment on attachment 8412533 [details] [diff] [review]
patch v1

Thanks derf, 
The perf should be readed in mainthread. Cancel review.

Comment 7

[Randy Lin [:rlin] - Be Mozillian on 2015/01/26]

Attachment: bug.patch

Simple way to block the source form video tags by checking image format.

Comment 8

[Randy Lin [:rlin] - Be Mozillian on 2015/01/26]

Attachment: check-in patch

Check-in patch
try:https://tbpl.mozilla.org/?tree=Try&rev=7ae25494d587

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/679f46bdebae

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/679f46bdebae

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g30_v1_4/rev/19727c12d0a7