Closed
Bug 1000736
Opened 10 years ago
Closed 10 years ago
Throw a not supported error if an app tries to record a video from a video file being transcoded into a stream
Categories
(Core :: Audio/Video: Recording, defect)
Tracking
()
People
(Reporter: jsmith, Assigned: rlin)
Details
Attachments
(2 files, 1 obsolete file)
1.25 KB,
patch
|
derf
:
review+
|
Details | Diff | Splinter Review |
1.55 KB,
patch
|
Details | Diff | Splinter Review |
1.4 wasn't intending to support video recording for transcoded video files, but it's currently exposed to the web. This is potentially bad for a few reasons: 1. Poor developer experience - a developer could think that the feature works, as some parts of video recording work here, but others do not. 2. Unintentional user side effects - a user gets negatively impacted from an app using an unsupported API with an unexpected side effect (e.g. crash) As such, we should throw a not supported error if someone tries to record a video using a transcoded file to avoid getting into this situation in the first place. Reference Bug List: * https://bugzilla.mozilla.org/show_bug.cgi?id=997593 * https://bugzilla.mozilla.org/show_bug.cgi?id=999891 * https://bugzilla.mozilla.org/show_bug.cgi?id=999894 * https://bugzilla.mozilla.org/show_bug.cgi?id=999896 * https://bugzilla.mozilla.org/show_bug.cgi?id=999897 * https://bugzilla.mozilla.org/show_bug.cgi?id=999900 * https://bugzilla.mozilla.org/show_bug.cgi?id=999901 * https://bugzilla.mozilla.org/show_bug.cgi?id=999904 * https://bugzilla.mozilla.org/show_bug.cgi?id=999906 * https://bugzilla.mozilla.org/show_bug.cgi?id=999909 * https://bugzilla.mozilla.org/show_bug.cgi?id=999912
Reporter | ||
Updated•10 years ago
|
blocking-b2g: --- → 1.4?
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → rlin
Assignee | ||
Updated•10 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•10 years ago
|
||
Hi Roc, Do you know how can I distinguish the media stream come from video tag or mozCamera?
Updated•10 years ago
|
blocking-b2g: 1.4? → 1.4+
What's actually causing the problems? Unexpected frame sizes or frame rates? If so we should simply check for the frame sizes and rates we want to support from the camera and reject everything else. I think we should do that instead of trying to detect transcoding specifically.
Flags: needinfo?(roc)
Assignee | ||
Comment 4•10 years ago
|
||
The encoder receive a new color format from omx decoder: OMX_QCOM_COLOR_FormatYUV420PackedSemiPlanar32m = 0x7FA30C04, the OMXWrapper need to handle this.
Assignee | ||
Comment 5•10 years ago
|
||
Check if the frame size is different with the gUM frame size and throw error. Also add check for the color format.
Attachment #8412533 -
Flags: review?(roc)
Assignee | ||
Updated•10 years ago
|
Attachment #8412533 -
Flags: feedback?(cku)
Assignee | ||
Comment 6•10 years ago
|
||
Comment on attachment 8412533 [details] [diff] [review] patch v1 Thanks derf, The perf should be readed in mainthread. Cancel review.
Attachment #8412533 -
Flags: review?(roc)
Attachment #8412533 -
Flags: feedback?(cku)
Assignee | ||
Comment 7•10 years ago
|
||
Simple way to block the source form video tags by checking image format.
Attachment #8413657 -
Flags: review?(tterribe)
Assignee | ||
Updated•10 years ago
|
Attachment #8412533 -
Attachment is obsolete: true
Updated•10 years ago
|
Attachment #8413657 -
Flags: review?(tterribe) → review+
Assignee | ||
Comment 8•10 years ago
|
||
Check-in patch try:https://tbpl.mozilla.org/?tree=Try&rev=7ae25494d587
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Comment 9•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/679f46bdebae
Keywords: checkin-needed
Comment 10•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/679f46bdebae
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
Comment 11•10 years ago
|
||
https://hg.mozilla.org/releases/mozilla-b2g30_v1_4/rev/19727c12d0a7
status-b2g-v1.4:
--- → fixed
status-b2g-v2.0:
--- → fixed
status-firefox30:
--- → wontfix
status-firefox31:
--- → wontfix
status-firefox32:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•