Throw a not supported error if an app tries to record a video from a video file being transcoded into a stream

RESOLVED FIXED in Firefox 32

Status

()

defect
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jsmith, Assigned: rlin)

Tracking

30 Branch
mozilla32
ARM
Gonk (Firefox OS)
Points:
---

Firefox Tracking Flags

(blocking-b2g:1.4+, firefox30 wontfix, firefox31 wontfix, firefox32 fixed, b2g-v1.4 fixed, b2g-v2.0 fixed)

Details

Attachments

(2 attachments, 1 obsolete attachment)

Reporter

Description

5 years ago
1.4 wasn't intending to support video recording for transcoded video files, but it's currently exposed to the web. This is potentially bad for a few reasons:

1. Poor developer experience - a developer could think that the feature works, as some parts of video recording work here, but others do not.
2. Unintentional user side effects - a user gets negatively impacted from an app using an unsupported API with an unexpected side effect (e.g. crash)

As such, we should throw a not supported error if someone tries to record a video using a transcoded file to avoid getting into this situation in the first place.

Reference Bug List:

* https://bugzilla.mozilla.org/show_bug.cgi?id=997593
* https://bugzilla.mozilla.org/show_bug.cgi?id=999891
* https://bugzilla.mozilla.org/show_bug.cgi?id=999894
* https://bugzilla.mozilla.org/show_bug.cgi?id=999896
* https://bugzilla.mozilla.org/show_bug.cgi?id=999897
* https://bugzilla.mozilla.org/show_bug.cgi?id=999900
* https://bugzilla.mozilla.org/show_bug.cgi?id=999901
* https://bugzilla.mozilla.org/show_bug.cgi?id=999904
* https://bugzilla.mozilla.org/show_bug.cgi?id=999906
* https://bugzilla.mozilla.org/show_bug.cgi?id=999909
* https://bugzilla.mozilla.org/show_bug.cgi?id=999912
Reporter

Updated

5 years ago
blocking-b2g: --- → 1.4?
Assignee: nobody → rlin
Status: NEW → ASSIGNED
Hi Roc, 
Do you know how can I distinguish the media stream come from video tag or mozCamera?
blocking-b2g: 1.4? → 1.4+
ni roc.
Flags: needinfo?(roc)
What's actually causing the problems? Unexpected frame sizes or frame rates? If so we should simply check for the frame sizes and rates we want to support from the camera and reject everything else. I think we should do that instead of trying to detect transcoding specifically.
Flags: needinfo?(roc)
The encoder receive a new color format from omx decoder: OMX_QCOM_COLOR_FormatYUV420PackedSemiPlanar32m = 0x7FA30C04, the OMXWrapper need to handle this.
Posted patch patch v1 (obsolete) — Splinter Review
Check if the frame size is different with the gUM frame size and throw error.
Also add check for the color format.
Attachment #8412533 - Flags: review?(roc)
Attachment #8412533 - Flags: feedback?(cku)
Comment on attachment 8412533 [details] [diff] [review]
patch v1

Thanks derf, 
The perf should be readed in mainthread. Cancel review.
Attachment #8412533 - Flags: review?(roc)
Attachment #8412533 - Flags: feedback?(cku)
Posted patch bug.patchSplinter Review
Simple way to block the source form video tags by checking image format.
Attachment #8413657 - Flags: review?(tterribe)
Attachment #8412533 - Attachment is obsolete: true
Attachment #8413657 - Flags: review?(tterribe) → review+
https://hg.mozilla.org/mozilla-central/rev/679f46bdebae
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
You need to log in before you can comment on or make changes to this bug.