1000928 - Dev Tools Themes: Debugger uses low-res gear image

Status: RESOLVED FIXED

(DevTools :: Debugger, defect)

Description

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: gears.png

In retina mode on a Mac, the debugger shows a low-res gear icon on the right, but the toolbox options icon is high-res.  We should use the high-res one everywhere.

Screenshot attached.

Comment 1

[Brian Grinstead [:bgrins]]

I have some changes that reorganize this in Bug 942292, but it shouldn't necessarily block this.

It still doesn't switch to the SVG icon, but this should be easy to do (use tool-options.svg instead of option-icon.png and delete the option-icon.png file).

Comment 2

[Brian Grinstead [:bgrins]]

Attachment: options-button-vector.patch

Can you check this out and see what you think?  Notice that there is no blue state available anymore on the vector icon, so I'm changing opacity when it opens instead.  It shouldn't be a big problem though - it is pretty obvious when the menu is opened.

Comment 3

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8411888 [details] [diff] [review]
options-button-vector.patch

Review of attachment 8411888 [details] [diff] [review]:
-----------------------------------------------------------------

Seems great to me!  Thanks.

Comment 4

[Brian Grinstead [:bgrins]]

https://hg.mozilla.org/integration/fx-team/rev/dbb1d4de276c
https://tbpl.mozilla.org/?tree=Fx-Team&rev=dbb1d4de276c

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/dbb1d4de276c