1000997 - 27 linter errors when linter tests run on TBPL

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Jonathan Griffin (:jgriffin)]

We have the gaia linter tests running on TBPL on cedar right now, but there are 27 linter failures reported, that don't seem to be reported by Travis:

https://tbpl.mozilla.org/php/getParsedLog.php?id=38360549&tree=Cedar&full=1

All of these seem valid but trivial.  I propose we fix them all with one patch.

Comment 1

[Julien Wajsberg [:julienw]]

Jonathan, can you confirm the gjslint version you use?

Also, can you show which command you run?

Thanks !

Comment 2

[Jonathan Griffin (:jgriffin)]

closure-linter 2.3.10; the command is just 'make lint'

Comment 3

[Julien Wajsberg [:julienw]]

Ok, it's not the latest; can you try with the latest version ? (2.3.13 currently, see http://code.google.com/p/closure-linter/downloads/list) 

Travis always downloads the latest version: https://github.com/mozilla-b2g/gaia/blob/master/tests/travis_ci/linters/install

Comment 4

[Jonathan Griffin (:jgriffin)]

Yep that seems to be the issue; I'll update the version we use in TBPL.

Comment 5

[Julien Wajsberg [:julienw]]

To be clear, we disable these errors in "make lint" but only newer versions of gjslint recognize the error numbers when disabling them...

Comment 6

[Jonathan Griffin (:jgriffin)]

Pushed a mozharness change to use 2.3.13:  https://hg.mozilla.org/build/mozharness/rev/310f2b4da4ad

Comment 7

[Jonathan Griffin (:jgriffin)]

This update fixed it..thanks julienw!

Comment 8

[Jordan Lund (:jlund)]

mozharness patch is in production: http://hg.mozilla.org/build/mozharness/rev/2947d4bd1276 :)