Closed Bug 1001327 Opened 10 years ago Closed 10 years ago

[Flame] enable NFC in nightly build

Categories

(Firefox OS Graveyard :: General, defect)

Product:
Firefox OS Graveyard
Component:
General
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking-b2g:2.0+, b2g-v2.0 fixed)

Status:
RESOLVED FIXED
Milestone:
2.0 S1 (9may)
Project Flags:
blocking-b2g 2.0+
Tracking Flags:
Tracking Status
b2g-v2.0 --- fixed

People

(Reporter: viralwang, Assigned: viralwang)

Details

(Whiteboard: NPOTB)

Attachments

(2 files, 1 obsolete file)

add manifest in master branch
52 bytes, text/x-github-pull-request
mwu
: review+
Details | Review
enable NFC support in flame
50 bytes, text/x-github-pull-request
mwu
: review+
Details | Review 
NFC still not working after system.img, new a bug for tracking

        Attachment #8413610 -
        Flags: review?(mwu)

    
    

    
  

      
      
      
      

        Attached file
          
        add NFC manifest in v1.4 branch (obsolete)
        — 
      

    


  

        Attachment #8413611 -
        Flags: review?(mwu)

    
    

    
  


  
Hi Michael,

We need to update manifest and device-flame to make NFC works.
Could you please help to review these PR?
Thanks!

        Attachment #8413612 -
        Flags: review?(mwu)

    
    

    
  
Comment on attachment 8413610 [details] [review]
add manifest in master branch

Please put the new entries in alphabetical order.

        Attachment #8413610 -
        Flags: review?(mwu) → review+

    
    

    
  
Comment on attachment 8413611 [details] [review]
add NFC manifest in v1.4 branch

I don't think backports need reviews unless there's something really different about the backport version.

        Attachment #8413611 -
        Flags: review?(mwu)

    
  

        Attachment #8413612 -
        Flags: review?(mwu) → review+

    
    

    
  
(In reply to Michael Wu [:mwu] from comment #4)
> Comment on attachment 8413610 [details] [review]
> add manifest in master branch
> 
> Please put the new entries in alphabetical order.

updated it in alphabetical order.

    
  
blocking-b2g: --- → 1.4?

    
    

    
  
also add reviewr in comment for attachment 8413612 [details] [review]

    
    

    
  
Is NFC planning to ship in 1.4 on production phones? I thought it was targeted for 2.0 to my understanding.

    
    

    
  
Clearing the 1.4  nom here since this is targeting 2.0
blocking-b2g: 1.4? → ---
Whiteboard: NPOTB

    
  
Keywords: checkin-needed

    
    

    
  
Comment on attachment 8413611 [details] [review]
add NFC manifest in v1.4 branch

remove patch for 1.4

        Attachment #8413611 -
        Attachment is obsolete: true

    
    

    
  
b2g-manifest/master: https://github.com/mozilla-b2g/b2g-manifest/commit/1fbc33c8f329d1d91fa53914826a8ece958f622f

device-flame/master: https://github.com/mozilla-b2g/device-flame/commit/2173c7c1f90ccd28915eed1d58077311d8296ec4
Assignee: nobody → vwang
Status: NEW → RESOLVED
Closed: 10 years ago

          status-b2g-v2.0:
          --- → fixed
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 2.0 S1 (9may)

    
    

    
  
Nominate to "1.4+". This change seems to fix Bug 1008000.
blocking-b2g: --- → 1.4?
Blocks: 1008000
blocking-b2g: 1.4? → 1.4+

    
  
Blocks: 1014485

    
    

    
  
This bug is for master. It is not appropriate to use this bug to track the bug of 1.4.
Lets use 1010993 to fix the performance issue of 1.4. I will nominate bug 1010993 as 1.4+.
No longer blocks: 1008000, 1010993, 1014485
blocking-b2g: 1.4+ → 2.0+

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: