Closed Bug 1001370 Opened 10 years ago Closed 10 years ago

Add a new type of shared element (pages) for the build system

Categories

(Firefox OS Graveyard :: Gaia::Build, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(b2g-v2.0 fixed)

RESOLVED FIXED
2.0 S1 (9may)
Tracking Status
b2g-v2.0 --- fixed

People

(Reporter: jmcf, Assigned: jmcf)

References

Details

Attachments

(1 file, 1 obsolete file)

for the work we are doing in separating the FTU from comms, we are going to need to put shared pages in the shared folder. That means we need to slightly modify the build process to support this new kind of shared item.
Attached file 18681.html (obsolete) —
Attachment #8412549 - Flags: review?(yurenju.mozilla)
Blocks: 950018
Comment on attachment 8412549 [details]
18681.html

hello guys,

I believe Yurenju is on PTO. In that case George, could you take over. 

I've seen that bug 968661 could also affect my patch. please let me know

thanks
Attachment #8412549 - Flags: feedback?(gduan)
Comment on attachment 8412549 [details]
18681.html

Hi Jose,
since bug 968661 has been landed, plz rebase your code to master and add test for it. Thanks.
Attachment #8412549 - Flags: feedback?(gduan)
Attachment #8412549 - Flags: review?(yurenju.mozilla)
Attached file 18742.html
Attachment #8413729 - Flags: review?(gduan)
Attachment #8412549 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Comment on attachment 8413729 [details]
18742.html

it looks good to me. r=gduan
Attachment #8413729 - Flags: review?(gduan) → review+
https://github.com/mozilla-b2g/gaia/commit/5e09ffe399cce7575011408fea4b7b43b3dcc148
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.0 S1 (9may)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: