Closed Bug 1001469 Opened 6 years ago Closed 2 years ago

Re-enable cycle collector optimization for nodes in the shadow tree

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla62
Tracking Status
firefox62 --- fixed

People

(Reporter: mccr8, Assigned: smaug)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Currently, we can't optimize nodes in the shadow tree out of the graph based on whether they are in document, because they can return true for being in document even if they are not owned by the document.
Andrew, looks like this got fixed. Can we fix this now? That flag is definitely not needed anymore in problematicFlags, but should the CC optimization be using GetComposedDoc instead? That should allow to really apply the optimization to shadow trees.
Flags: needinfo?(continuation)
my first "got fixed" is about the "nodes in shadow trees report to be in the document".
I don't know. Hopefully Olli does.
Flags: needinfo?(continuation) → needinfo?(bugs)
No longer blocks: shadowdom-initial-release
Flags: needinfo?(bugs)
Using IsInComposedDoc should be fine these days, I think
Blocks: shadowdom
We may want to change OwnedOnlyByTheDOMTree to make optimizations more effective.
As explained in the previous comment, Shadow Root is handled sort of like another child node, so this should be fine. But let's see what tryserver thinks.
(manually running wpt shadow DOM tests didn't reveal leaks.)

remote: View your change here:
remote:   https://hg.mozilla.org/try/rev/349c4959dad0cca1f14a6423e1cb4c2624b7256a
remote: 
remote: Follow the progress of your build on Treeherder:
remote:   https://treeherder.mozilla.org/#/jobs?repo=try&revision=349c4959dad0cca1f14a6423e1cb4c2624b7256a
remote: recorded changegroup in replication log in 0.113s
Assignee: nobody → bugs
Attachment #8974955 - Flags: review?(continuation)
Attachment #8974955 - Flags: review?(continuation) → review+
Pushed by opettay@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/99e338bc3709
Re-enable cycle collector optimization for nodes in the shadow tree, r=mccr8
https://hg.mozilla.org/mozilla-central/rev/99e338bc3709
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
Depends on: 1461704
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.