Closed Bug 1001469 Opened 6 years ago Closed 2 years ago
Re-enable cycle collector optimization for nodes in the shadow tree
Currently, we can't optimize nodes in the shadow tree out of the graph based on whether they are in document, because they can return true for being in document even if they are not owned by the document.
Andrew, looks like this got fixed. Can we fix this now? That flag is definitely not needed anymore in problematicFlags, but should the CC optimization be using GetComposedDoc instead? That should allow to really apply the optimization to shadow trees.
my first "got fixed" is about the "nodes in shadow trees report to be in the document".
I don't know. Hopefully Olli does.
Flags: needinfo?(continuation) → needinfo?(bugs)
No longer blocks: shadowdom-initial-release
Using IsInComposedDoc should be fine these days, I think
We may want to change OwnedOnlyByTheDOMTree to make optimizations more effective.
these days host element owns the ShadowRoot https://searchfox.org/mozilla-central/rev/3f17a234769d25fca5144ebb8abc8e1cb3c56c16/dom/base/FragmentOrElement.h#210 and ShadowRoot owns the host https://searchfox.org/mozilla-central/rev/3f17a234769d25fca5144ebb8abc8e1cb3c56c16/dom/base/DocumentFragment.h#107
As explained in the previous comment, Shadow Root is handled sort of like another child node, so this should be fine. But let's see what tryserver thinks. (manually running wpt shadow DOM tests didn't reveal leaks.) remote: View your change here: remote: https://hg.mozilla.org/try/rev/349c4959dad0cca1f14a6423e1cb4c2624b7256a remote: remote: Follow the progress of your build on Treeherder: remote: https://treeherder.mozilla.org/#/jobs?repo=try&revision=349c4959dad0cca1f14a6423e1cb4c2624b7256a remote: recorded changegroup in replication log in 0.113s
Assignee: nobody → bugs
Attachment #8974955 - Flags: review?(continuation)
Attachment #8974955 - Flags: review?(continuation) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/99e338bc3709 Re-enable cycle collector optimization for nodes in the shadow tree, r=mccr8
You need to log in before you can comment on or make changes to this bug.