1001471 - My back button is trying to eat the plugin notification icon

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[Dave Townsend [:mossop]]

Attachment: screenshot

Remains after an update and restart to current nightly. Pages without plugins look fine.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Tentatively blaming bug 997131, just based on timing.

Comment 4

[Dão Gottwald [:dao]]

Attachment: patch

Comment 5

[Mike de Boer [:mikedeboer]]

Comment on attachment 8414466 [details] [diff] [review]
patch

I approve! Thanks for fixing this Dão.

Comment 6

[Dão Gottwald [:dao]]

https://hg.mozilla.org/integration/fx-team/rev/70f607cb0e35

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/70f607cb0e35

Comment 9

[Dão Gottwald [:dao]]

Comment on attachment 8414466 [details] [diff] [review]
patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 997131
User impact if declined: small visual glitch
Testing completed (on m-c, etc.): landed on m-c
Risk to taking this patch (and alternatives if risky): very low
String or IDL/UUID changes made by this patch: none

Comment 10

[Francesca Ciceri [:madamezou]]

Hi,

I wasn't able to reproduce it in the affected version (merely because I don't know how to run an automatic update to a nightly which is *not* the latest nightly - but the affected one).

On the other hand, I can confirm that the bug is no longer present in the latest nightly: Mozilla/5.0 (X11; Linux x86_64; rv:32.0) Gecko/20100101 Firefox/32.0 ID:20140429030201 CSet: d7c07694f339.

Is this enough to consider it verified? Or is there a way to force the automatic update to a specific nightly, so to have the usual verification process?

Thanks,
Francesca

Comment 11

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8414466 [details] [diff] [review]
patch

Hello Francesca ;)

Comment 12

[Dão Gottwald [:dao]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/627ab75edc83

Comment 14

[Liz Henry (:lizzard) (privacy/fingerprinting team)]

Francesca, I think you can ignore the updating process, and just look at the previously affected version of Nightly from the 25th, which I think is here: http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014-04-25-03-02-09-mozilla-central/.  Then you could check to see if you see the original bug.

Comment 15

[Francesca Ciceri [:madamezou]]

Hi Liz,

(In reply to Liz Henry :lizzard from comment #14)
> Francesca, I think you can ignore the updating process, and just look at the
> previously affected version of Nightly from the 25th, which I think is here:
> http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014-04-25-03-02-09-
> mozilla-central/.  Then you could check to see if you see the original bug.

thanks for the hint!
I've been able to verify the bug on the 25th Nightly build, and I can confirm is no longer present in:

- latest Nightly Mozilla/5.0 (X11; Linux x86_64; rv:32.0) Gecko/20100101 Firefox/32.0 ID:20140512030202 CSet: 20ca234fd62b

- latest Aurora Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Firefox/31.0 ID:20140512004006 CSet: 77f4f17f54d3