1001564 - Add clean-css and uglify packages to MDN servers

Status: RESOLVED FIXED

(Infrastructure & Operations Graveyard :: WebOps: Community Platform, task)

Description

[David Walsh :davidwalsh]

With regard to this PR:

https://github.com/mozilla/kuma/pull/2298

We'd like to install clean-css and uglify-js2 to dev, staging, and prod servers for MDN.  This will allow us to better minify assets.

Comment 1

[David Walsh :davidwalsh]

https://github.com/mozilla/kuma/pull/2298

That PR will do the following to our dev boxes, and we'd like the same for dev, staging, and prod:

1.  Upgrade stylus to `0.42.1`
2.  Add clean-css at `2.1.8`
3.  Add uglify at `2.4.13`

This will be another push-freeze situation as we upgrade each machine because a `settings.py` change (adding paths to clean-css and uglify) is important.

Chris, when would this work into your schedule?  Early in the week is probably best.  Thank you!

Comment 2

[Les Orchard [:lorchard]]

Possibly a weird thought: We've got several node.js dependencies in Kuma, now. Rather than continuing to treat them as one-off installs, would it help to add a package.json file listing them and run `npm install` in our push scripts? 

Weird, because Kuma itself is not a node.js project, but that would at least let us self-service upgrades to node.js package dependencies. (Assuming they're all pure JS, unlike the fibers module that requires compiling a binary lib)

Comment 3

[Chris Turra [:cturra]]

(In reply to Les Orchard [:lorchard] from comment #2)
> Possibly a weird thought: We've got several node.js dependencies in Kuma,
> now. Rather than continuing to treat them as one-off installs, would it help
> to add a package.json file listing them and run `npm install` in our push
> scripts? 

unfortunately not. our security policy requires all packages to come from a signed source. therefore, at this point, we're stuck creating custom rpm's for each package that is not included in a trusted/signed yum repo. boo-urns, i know, but that's what we're stuck with at this point.

Comment 4

[Les Orchard [:lorchard]]

(In reply to Chris Turra [:cturra] from comment #3)

> boo-urns, i know, but that's what we're stuck with at this point.

Yuck, but yeah, fair enough.

Comment 5

[David Walsh :davidwalsh]

Ping on this Chris.  Can we schedule this for next week?  Updated to do:

1.  Upgrade stylus to `0.42.1`
2.  Add clean-css at `2.1.8`
3.  Add uglify at `2.4.13`

Once these are available, we need to merge and push this:

https://github.com/mozilla/kuma/pull/2298

Comment 6

[Chris Turra [:cturra]]

as discussed yesterday, we've scheduled time on 06/25 to push this through.

Comment 7

[Chris Turra [:cturra]]

i have rolled out the upgrade to stylus and added clean-css and uglify-js to the developeradm node, which is where the minifying happens during deployments. they're pinned to the following versions as discussed:

 - nodejs-stylus.noarch == 0.43.1-1.el6
 - nodejs-clean-css.noarch == 0.2.6-1.el6
 - uglify-js.noarch ==  2.4.13-5.el6


marking this bug as r/fixed.

there is a *chance* that these might need to be rolled back. if that's the case, please don't hesitate to reopen this bug and ping me :)

Comment 8

[David Walsh :davidwalsh]

In re-reviewing this info, and a quick spot check of the site, I noticed the clean-css version I was looking for was:

2.1.8

And we installed:

0.2.6

That appears to be much older and something we likely do not want.

Comment 9

[Chris Turra [:cturra]]

you're right, i read that version at 2.6, which was incorrect according to the package.

 [[e-mail]3 ~]# yum info nodejs-clean-css.noarch | grep Version
 Version     : 0.2.6


as a result, i went ahead and built a custom clean-css rpm from upstream npm.

 [[e-mail]3 ~]# cleancss -v
 2.2.3