1001587 - nsGenericDOMDataNode's Traverse method doesn't need to call BindingManager()->Traverse()

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Andrew McCreight [:mccr8]]

Currently, it does.  But the first thing that nsBindingManager::Traverse does is:

1014   if (!aContent->HasFlag(NODE_MAY_BE_IN_BINDING_MNGR) ||
1015       !aContent->IsElement()) {

and return without doing anything if it is true.  bz said nsGenericDOMDataNode isn't an element, so I think this call will never do anything.  It is a little confusing having it in there, in my opinion, so I think it should be removed.  Let me know if I am misunderstanding something.

Comment 1

[Andrew McCreight [:mccr8]]

I think this is a consequence of bug 796061, which moved a few things out of the binding manager into the node itself.

Comment 2

[Andrew McCreight [:mccr8]]

Attachment: nsGenericDOMDataNode's Traverse method doesn't need to call nsBindingManager::Traverse.

The stuff from nsBindingManager::Traverse that is used for data nodes
was removed in bug 796061, so it now just returns immediately for
non-elements, so we don't need to call it any more in data nodes.

try run: https://tbpl.mozilla.org/?tree=Try&rev=00aafe8bcef0

Comment 3

[Andrew McCreight [:mccr8]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a249af412db8

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/a249af412db8