Remove nsIContent hashtables from nsBindingManager.

RESOLVED FIXED in mozilla25

Status

()

Core
XBL
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: wchen, Assigned: wchen)

Tracking

(Blocks: 1 bug)

unspecified
mozilla25
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments, 3 obsolete attachments)

(Assignee)

Description

5 years ago
nsBindingManager has some hashtables that store XBL information about nsIContent. This information can be stored on the nsIContent and would naturally lead to a simpler API because you wouldn't need to obtain the binding manager for getting and setting the XBL attributes.
(Assignee)

Comment 1

5 years ago
Created attachment 666642 [details] [diff] [review]
Part 1: Remove mBindingTable from nsBindingManager.
Attachment #666642 - Flags: review?(mrbkap)
(Assignee)

Comment 2

5 years ago
Created attachment 666643 [details] [diff] [review]
Part 2: Remove mInsertionParentTable from nsBindingManager.
Attachment #666643 - Flags: review?(mrbkap)
I'm worried that this is going to bitrot the patches in bug 653881 a bunch. Would it be worth trying to drive those into the tree instead?

Or is the idea to do so piece-wise and this is part of that?
(Assignee)

Comment 4

5 years ago
(In reply to Jonas Sicking (:sicking) from comment #3)
> I'm worried that this is going to bitrot the patches in bug 653881 a bunch.
> Would it be worth trying to drive those into the tree instead?
> 
> Or is the idea to do so piece-wise and this is part of that?

I've based these patches on top of bug 653881 so I depend on the other patches going in the tree first.
Ooh, I see! Awesome!

Updated

5 years ago
Blocks: 811542

Updated

5 years ago
Attachment #666642 - Flags: review?(mrbkap)

Updated

5 years ago
Attachment #666643 - Flags: review?(mrbkap)
(Assignee)

Comment 6

4 years ago
Created attachment 764490 [details] [diff] [review]
Bug 796061 - Part 1: Remove mBindingTable from nsBindingManager.
Attachment #666642 - Attachment is obsolete: true
Attachment #764490 - Flags: review?(mrbkap)
(Assignee)

Comment 7

4 years ago
Created attachment 764506 [details] [diff] [review]
Part 2: Remove mInsertionParentTable from nsBindingManager.
Attachment #666643 - Attachment is obsolete: true
Attachment #764506 - Flags: review?(mrbkap)
Comment on attachment 764490 [details] [diff] [review]
Bug 796061 - Part 1: Remove mBindingTable from nsBindingManager.

Review of attachment 764490 [details] [diff] [review]:
-----------------------------------------------------------------

It seems like NODE_MAY_BE_IN_BINDING_MGR might be a prime target for collection after this patch.
Attachment #764490 - Flags: review?(mrbkap) → review+

Updated

4 years ago
Attachment #764506 - Flags: review?(mrbkap) → review+
(Assignee)

Comment 9

4 years ago
Created attachment 776704 [details] [diff] [review]
Part 1: Remove mBindingTable from nsBindingManager.
Attachment #764490 - Attachment is obsolete: true
Attachment #776704 - Flags: review?(mrbkap)
(Assignee)

Comment 10

4 years ago
Created attachment 776705 [details] [diff] [review]
Remove mBindingTable from nsBindingManager. v1 diff v2

Updated

4 years ago
Attachment #776704 - Flags: review?(mrbkap) → review+
(Assignee)

Comment 11

4 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/5e3d564cd1b5
https://hg.mozilla.org/integration/mozilla-inbound/rev/d810dcc0726f
https://hg.mozilla.org/mozilla-central/rev/5e3d564cd1b5
https://hg.mozilla.org/mozilla-central/rev/d810dcc0726f
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25

Updated

4 years ago
Depends on: 897386
You need to log in before you can comment on or make changes to this bug.