1001757 - Add ability to store core apps outside of profile on B2G Desktop

Status: RESOLVED FIXED

(Core Graveyard :: DOM: Apps, defect)

Description

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

On desktop, we need a way to set a pref that will allow us to store certified apps in a different place than the profile, so that we can simulate profile updates in integration tests.

See Bug 1001680 Comment #2 for more info.

Comment 1

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

This will most likely be by setting a debug pref to let the system know that we are trying to run upgrade tests.

Comment 2

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Talked to fabrice about this on IRC. Going to set up a pref (b2g.apps.desktop_coreappsdir) to point to where core apps are built. Will need to change this in the B2G directory provider, as well as the gaia build system, and make sure they sync up. After this, we should be able to provide a location to build the apps into, then redistribute profiles as necessary for testing.

Also talked about having a command line argument for core app location, which the more I think about it, could be useful as an override for this without having to go in and edit prefs. Worth doing both maybe?

Comment 3

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Attachment: Patch 1 (v1) - Add ability to store core apps outside of profile on desktop B2G

Comment 4

[GitHub Autolander Bot]

Attachment: [gaia] qdot:1001757-move-core-apps > mozilla-b2g:master

Comment 5

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Comment on attachment 8576329 [details] [review]
[gaia] qdot:1001757-move-core-apps > mozilla-b2g:master

Gaia build system changes for building core apps outside of the profile on b2g desktop. Contains integration tests for making sure external app directory building works.

Comment 6

[Ricky Chien [:rickychien] (inactive)]

Comment on attachment 8576329 [details] [review]
[gaia] qdot:1001757-move-core-apps > mozilla-b2g:master

Sorry I don't totally understand here =(
If you want to modify PROFILE_DIR, you could do

PROFILE_DIR?=$(GAIA_DIR)$(SEP)$(PROFILE_FOLDER)

Comment 7

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Comment on attachment 8576329 [details] [review]
[gaia] qdot:1001757-move-core-apps > mozilla-b2g:master

Ok. I fixed the ?= and the github comment.

The reason I needed to move PROFILE_DIR up to its own variable instead of just having it in config is because before this patch, we assumed that the webapps dir that gaia builds would be in PROFILE_DIR. After this patch, we can now relocate the webapps dir wherever we want, mostly for upgrade testing purposes. We'll need to keep PROFILE_DIR the same (because we still want the profile in $GAIA_DIR/profile), and for most cases, we'll want to keep webapps in PROFILE_DIR too.

Comment 8

[Ricky Chien [:rickychien] (inactive)]

Comment on attachment 8576329 [details] [review]
[gaia] qdot:1001757-move-core-apps > mozilla-b2g:master

OK, it seems fine to me. 

Could you tell me more detail steps of how do you simulate profile updates in integration tests? Thanks

Comment 9

[[:fabrice] Fabrice Desré]

Comment on attachment 8576307 [details] [diff] [review]
Patch 1 (v1) - Add ability to store core apps outside of profile on desktop B2G

Review of attachment 8576307 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with nits fixed

::: b2g/components/DirectoryProvider.js
@@ +15,4 @@
>  const LOCAL_DIR = "/data/local";
>  const UPDATES_DIR = "updates/0";
>  const FOTA_DIR = "updates/fota";
> +const DESKTOP_COREAPPSDIR_PREF = "b2g.apps.desktop_coreappsdir"

nit: I would just call it b2g.coreappsdir

::: modules/libpref/init/all.js
@@ +4631,5 @@
>  pref("dom.secureelement.enabled", false);
>  #endif
> +
> +// Preference for moving where desktop b2g apps are stored.
> +pref("b2g.apps.desktop_coreappsdir", "")
\ No newline at end of file

I don't think you need that since DirectoryProvider.js can deal with the pref being not set at all.

Comment 10

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

https://hg.mozilla.org/integration/b2g-inbound/rev/354bc06774a0

Comment 11

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Gaia merge: https://github.com/mozilla-b2g/gaia/pull/28818

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/354bc06774a0