1001820 - browser_uitour.js fails on linux 32+64 while running as a standalone directory

Status: NEW

(Firefox :: Tours, defect)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

in bug 992911 we are working on running the browser-chrome tests as a standalone directory and not as a large chunk of tests.  This is causing some tests to fail when they depend on other settings or future tests to help them clean up.

In this case browser_UITour.js gives this error (https://tbpl.mozilla.org/php/getParsedLog.php?id=38517295&tree=Try):
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/modules/test/browser_UITour.js | The animation-name should be uitour-zoom - Got none, expected uitour-zoom

this is on opt and debug:
https://tbpl.mozilla.org/?tree=Try&rev=1ef160324a55

I see in bug 951965 there are other errors for this test case and even a whiteboard entry indicating it is disabled on linux (which isn't true)

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

this is still a problem in a recent build, see bc2 on this try push:
https://tbpl.mozilla.org/?tree=Try&rev=b00b60c5af30

link to linux32 opt:
https://tbpl.mozilla.org/php/getParsedLog.php?id=44176066&tree=Try

My goal is to turn these on as --run-by-dir mode in 2 weeks, we don't have too many tests (19 total) that are problematic, if we can fix the easy ones now that will help!

Paolo, can you figure out why we get these errors while running the only the tests in the modules/test/ directory?

Comment 2

[:Paolo Amadini]

(In reply to Joel Maher (:jmaher) from comment #1)
> this is still a problem in a recent build, see bc2 on this try push:
> https://tbpl.mozilla.org/?tree=Try&rev=b00b60c5af30
> 
> link to linux32 opt:
> https://tbpl.mozilla.org/php/getParsedLog.php?id=44176066&tree=Try
> 
> My goal is to turn these on as --run-by-dir mode in 2 weeks, we don't have
> too many tests (19 total) that are problematic, if we can fix the easy ones
> now that will help!
> 
> Paolo, can you figure out why we get these errors while running the only the
> tests in the modules/test/ directory?

Adding a needinfo request for MattN based on the log of the file, he might notice something that is obviously wrong with it. If there is nothing obvious, I can help with testing on a Linux machine.

Comment 3

[Matthew N. [:MattN]]

It's probably more panel weirdness on Linux. The test was disabled on Linux before we split it so maybe this first piece should be disabled on Linux again.

Comment 4

[Matthew N. [:MattN]]

(In reply to Joel Maher (:jmaher) from comment #0)
> I see in bug 951965 there are other errors for this test case and even a
> whiteboard entry indicating it is disabled on linux (which isn't true)

It is disabled and was when this was filed AFAICT. Is this still failing somehow with --run-by-dir?

Comment 5

[Joel Maher ( :jmaher ) (UTC -8)]

in this case, we have a bug filed, it was disabled after that for other reasons, and this bug is still useful to track for when we enable the test case again.  This shouldn't be blocking our progress for turning --run-by-dir on.

Comment 6

[Matthew N. [:MattN]]

I was saying in comment 4 that the test was disabled before this bug was filed AFAICT. Do you see something different?

Comment 7

[Joel Maher ( :jmaher ) (UTC -8)]

ah, I think I know why I ran into this- there was a bug a few months ago where the manifest parser would fail to exclude conditions when there were multiple conditions (i.e. linux || e10s).  In this case I think adding e10s broke this and I ended up seeing it running.

Maybe we can close this bug?

Comment 8

[Matthew N. [:MattN]]

Moving open UITour bugs to Firefox::Tours. Filter on firefox-tours-20150121.