1001848 - (Glow2014) Country names are displayed in English for some locales

Status: RESOLVED FIXED

(Websites :: glow.mozilla.org, defect)

Description

[Francesco Lodolo [:flod]]

Problem is that locale for Spanish is "es", while in products Spanish is "es-ES".

If I copy prod_details_json/regiones/es-ES.json as es.json, country names are correctly displayed in Spanish.

Comment 1

[Francesco Lodolo [:flod]]

Actually the list is longer.

es (product es-ES)
pt-br (product pt-BR)
zh-cn (product zh-CN)
zh-TW (product zh-TW)

Comment 2

[Kohei Yoshino [:kohei]]

Those don't affect l10n but are also different from Mozilla's usual locale naming convention:

en (product en-US)
en-gb (product en-GB)

Comment 3

[Paul [:pmac] McLanahan]

(In reply to Francesco Lodolo [:flod] from comment #1)
> Actually the list is longer.
> 
> es (product es-ES)
> pt-br (product pt-BR)
> zh-cn (product zh-CN)
> zh-TW (product zh-TW)

I see the 'es' issue, but those others seem to work fine for me. Is there a problem with them working on the site? I'll special-case "es" so that "es-ES" is used.

Comment 4

[[github robot]]

Commit pushed to master at https://github.com/mozilla/mrburns

https://github.com/mozilla/mrburns/commit/1e88b4fa165431541bc4bd3d4fa5a0581ff9d86a
Fix bug 1001848: Treat 'es' locale as 'es-ES' for country names.

Comment 5

[Francesco Lodolo [:flod]]

(In reply to Paul McLanahan [:pmac] from comment #3)
> I see the 'es' issue, but those others seem to work fine for me. Is there a
> problem with them working on the site? 

https://webwewant.allizom.org/zh-TW is not available
https://webwewant.allizom.org/zh-tw is available

Go in "Facts & figues" and you'll see the country names in English. 
Now go in prod_details_json/regions, copy zh-TW.json as zh-tw.json, and you'll see the names in the correct locale.

Comment 6

[Paul [:pmac] McLanahan]

That's odd. It works for zh-tw locally for me. I'll see if I can fix this for good.

Comment 7

[[github robot]]

Commit pushed to master at https://github.com/mozilla/mrburns

https://github.com/mozilla/mrburns/commit/1e6f8fb54a316a47fe58992de2c56b19bfe71eec
Fix bug 1001848: Fix locales for countries list l10n.

Comment 8

[Peter Pin-Guang Chen [:petercpg] (MozTW.org)]

I still see some names are not translated, including British Antarctic Territory, Curaçao, Kosovo, and South Sudan. Where can I update them or just leave it alone?

Comment 9

[Francesco Lodolo [:flod]]

Apparently those countries are not part of Product details, so I don't think we can translate them.
For example there's "Sudan" but not "South Sudan", "Antarctica" but not "British Antarctic Territory".

I wonder if we could hide them from the list.

Comment 10

[Paul [:pmac] McLanahan]

(In reply to Francesco Lodolo [:flod] from comment #9)
> Apparently those countries are not part of Product details, so I don't think
> we can translate them.
> For example there's "Sudan" but not "South Sudan", "Antarctica" but not
> "British Antarctic Territory".
> 
> I wonder if we could hide them from the list.

I can change the names. These are just country codes that show up in our data but not in prod_details.

https://github.com/mozilla/mrburns/blob/master/mrburns/settings/base.py#L113-L123

If instead of new names you know to which country codes we do have I should map the others, I can just do that.

Comment 11

[Francesco Lodolo [:flod]]

Clearing needinfo per discussion on IRC.