987191 - (Glow:L10NTemplates) L10n-ify Templates

Status: VERIFIED FIXED

(Websites :: glow.mozilla.org, defect)

Description

[Ben (:bensternthal)]

Capturing some notes from the l10n team:

1. For right-to-left languages, buttons with icons, icons should be on right side

2. Traditional Chinese can be dense, note for privacy and other small fonts - this may be hard to read.

3. Share your web icon, left-to-right icon

4. Download number needs to be localized (points not commas)

5. For country lists (dropdown on stats page) L10n noted this should be in localized order - they also mentioned this is difficult. We may not be able to address in our timeframe.

Comment 2

[Tomer Cohen :tomer]

(In reply to Ben (:bensternthal) from comment #0)
> 1. For right-to-left languages, buttons with icons, icons should be on right
> side

This issue doesn't cover only buttons, as the string themselves should be dir=rtl in RTL locales. Please see bug 1001319 for STR.

Comment 3

[Ben (:bensternthal)]

Formatting the number looks to be pretty complex. We are outputting this number via js.

As far as i can tell we would need to manually maintain a list. Given the time I would say do not worry about localizing the number. The R to L stuff is much more important.

Comment 4

[Ben (:bensternthal)]

Steven:

As far as I can tell we only have 1 RTL language. The site is in pretty rough shape with RTL turned on. Including issues with the glows on the map and a lot of other stuff.

I do not think you will be able to complete these changes in time. As much as I hate to say it I think we will need to launch without Hebrew (I think this is the only RTL) turning this on as soon as we can after launch.

Please confirm if this is also your recommendation.

Comment 5

[Tomer Cohen :tomer]

(In reply to Ben (:bensternthal) from comment #4)
> As far as I can tell we only have 1 RTL language. The site is in pretty
> rough shape with RTL turned on. Including issues with the glows on the map
> and a lot of other stuff.

It could be less time-consuming task to enable RTL only to text elements, which would make the site readable. Switching the location of the icons to the beginning of the text is also nice-to-have and would be faster to implement than having a full RTL theme. Later we could replace these selectors with a full RTL support.

Comment 6

[Ben (:bensternthal)]

Im most concerned about some issues i saw with the map. The location of the glows is off when i turned RTL on. This is not likely to be a quick fix and we are super close to launch. Stress!!

Comment 7

[Tomer Cohen :tomer]

(In reply to Ben (:bensternthal) from comment #6)
> Im most concerned about some issues i saw with the map. The location of the
> glows is off when i turned RTL on. This is not likely to be a quick fix and
> we are super close to launch. Stress!!

What if only those problematic elements are kept as LTR?

Comment 8

[Kohei Yoshino [:kohei]]

I'm taking a look at this. Maybe not so difficult to fix.

Comment 9

[Francesco Lodolo [:flod]]

(In reply to Ben (:bensternthal) from comment #3)
> As far as i can tell we would need to manually maintain a list. Given the
> time I would say do not worry about localizing the number. The R to L stuff
> is much more important.

I strongly disagree ;-) 

I'm not sure comma is the most common character used as thousands separator.
http://www.unicode.org/cldr/charts/latest/by_type/numbers.symbols.html#a1ef41eaeb6982d

How would you feel having dots instead of commas as an English user? It would look confusing, or just wrong.

Can we settle on replacing the comma with a different character, for example a punctuation space? 
http://www.fileformat.info/info/unicode/char/2008/index.htm

Comment 10

[Ben (:bensternthal)]

Understood. Ok I think i can handle putting in a comma or a point depending on locale. I may spin that off into a sep bug.

I want to be sure I have an accurate list of countries who use comma or point (of the subset we are translating for) and am unsure/having trouble understanding the chart

Based on this list in verbatim https://localize.mozilla.org/projects/glow2014/ can you tell me what gets what? Or explain how i can use that chart :)

Comment 11

[Ben (:bensternthal)]

Sep bug 1001887 to cover localizing the umber. Please add any further discussion there.

Comment 12

[Kohei Yoshino [:kohei]]

:tchevalier filed Bug 1001967 for the RTL issues and I sent https://github.com/mozilla/mrburns/pull/153 to fix most of them.

Comment 13

[Rebecca Billings [:rbillings]]

I can see RtL display on https://webwewant.allizom.org/he/, should this be resolved fixed?

Comment 14

[Ben (:bensternthal)]

Testing this on dev - it looks really good. Definitely IMHO good enough to launch with.

I would like rbillings to do some quick testing but outside of that .. great work!

I checked the usual chrome and ff on mac and pc and android + chrome on mobile. Also briefly on ios.

We could not have done this without you.

Comment 15

[Rebecca Billings [:rbillings]]

Attachment: Screen Shot 2014-04-28 at 9.21.49 AM.png

Is there a reverse FF logo that can be used- or is this expected?

Comment 16

[Rebecca Billings [:rbillings]]

Also: the font on Safari [screenshot above] looks a lot less...nice... than the FF or Chrome version.

Comment 17

[Kohei Yoshino [:kohei]]

(In reply to Rebecca Billings [:rbillings] from comment #15)
> Is there a reverse FF logo that can be used- or is this expected?

English words are LTR even in a RTL paragraph. It should be okay.

(In reply to Rebecca Billings [:rbillings] from comment #16)
> Also: the font on Safari [screenshot above] looks a lot less...nice... than
> the FF or Chrome version.

Confirmed. Looks like we have to specify the Arial Hebrew font. Will send a pull request shortly.

Comment 18

[Kohei Yoshino [:kohei]]

Attachment: Pull request: Fix the Hebrew font issue on Safari

Comment 19

[Rebecca Billings [:rbillings]]

Verified Safari font update, ok on the FF logo. Everything else looks implemented- filing issues separately.