1001887 - (Glow:L10NNumber) Localize Number

Status: VERIFIED FIXED

(Websites :: glow.mozilla.org, defect)

Description

[Ben (:bensternthal)]

Put in comma or point depending on locale.

See bug 987191#c9 for discussion and context

Comment 1

[Francesco Lodolo [:flod]]

Based on 
http://www.unicode.org/cldr/charts/latest/by_type/numbers.symbols.html#a1ef41eaeb6982d

And also on some style guides from Microsoft
https://www.microsoft.com/Language/en-US/StyleGuides.aspx

comma (,) = en, he, ko, ja, zh-CN, zh-TW
dot (.) = de, es, id, it, nl, pt-BR, ro
space = cs, fr, hu, pl, ru, sk, sq

Personally I think we should use the space as fallback (more readable, for sure less confusing than having the decimal separator character used as group separator), or maybe leave it empty.

Comment 2

[Francesco Lodolo [:flod]]

Adding sl and lt, since they might be ready for launch

comma (,) = en, he, ko, ja, zh-CN, zh-TW
dot (.) = de, es, id, it, nl, pt-BR, ro, sl
space = cs, fr, hu, lt, pl, ru, sk, sq

Comment 3

[Kohei Yoshino [:kohei]]

Attachment: pull request

It's time to use ECMAScript Intl API.

Comment 4

[Ben (:bensternthal)]

I had the wrong bug id in my pr.

This was merged in: https://github.com/mozilla/mrburns/pull/150

Comment 5

[Rebecca Billings [:rbillings]]

Verified