1002314 - [B2G]To have a webapi providing WIFI capabilities of device

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Wifi, defect)

Description

[Ken Chang[:kenkai]]

This is a follow up bug for https://bugzilla.mozilla.org/show_bug.cgi?id=966925#c19.
We need to add a webapi providing WIFI capabilities of device so that Gaia can show options of WIFI setting accurately.

Comment 1

[Ken Chang[:kenkai]]

Vincent, It seems that we need this in 2.0 because the options of wifi setting are different in various devices. If the target milestons does work for you, please change it.

Comment 2

[Ken Chang[:kenkai]]

Chuck is going to handle this.

Comment 3

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

Add |DOMRequest WifiManager.getCapabilities()|, and returns an object containing wifi capabilities.

The problem now is how much info we should return, Gaia is more likely to have a complete list so settings app can create UI in a general way, especially for WPA-EAP.

Maybe like:
{
  security: {
    OPEN: null,
    WEP: {
      password: {
        ASCII: { 
          length: [
            {min: 5, max: 5},
            {min: 13, max: 13}
          ]
        },
        HEX: {
          length: [
            {min: 10, max: 10},
            {min: 26, max: 26}
          ]
        }
      }
    },
    WPA-PSK: {
      password: {
        ASCII: {
          length: [
            {min: 8, max: 64}
          ]
        }
      }
    },
    WPA-EAP: {
      SIM: {},
      PEAP: {
        identity: {},
        password: {},
        phase2: [
          "MSCHAPV2"
        ],
        certs: [
          "SERVER"
        ]
      },
      TTLS: {
        identity: {},
        password: {},
        phase2: [
          "MSCHAPV2"
        ],
        certs: [
          "SERVER"
        ]
      },
      TLS: {
        identity: {},
        certs: [
          "SERVER",
          "USER",
          "PRIVATEKEY"
        ]
      }
    }
  }
}

But creating object with such detail seems almost like using XUL...
Any suggestions?

Comment 4

[Arthur Chen [:arthurcc][inactive after 6/30]]

I would suggest only pass the information that is device or platform dependent. For example, if the password length is fixed, we can simply hard code it in gaia side.

Comment 5

[Blake Kaplan (:mrbkap) (inactive)]

I agree with Arthur. A lot of the information in your sample object is findable on wikipedia. It should be enough to say that we support WPA-PSK and obviously that has a password. I'd expect this to be more a list of capabilities (with some nesting to break out which sorts of keys we support for WPA-EAP and friends).

Comment 6

[Vincent Chang[:vchang][changyihsin]]

How about sometimes like this ?
{
  security: {
    OPEN,
    WEP,
    WPA-PSK,
    WPA-EAP: {
      SIM,
      PEAP,
      TTLS,
      TLS
    }
  }
}

Comment 7

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

I think Phase 2 can be dynamic, too.

{
  security: {
    OPEN: {},
    WEP: {},
    WPA-PSK: {},
    WPA-EAP: {
      SIM: {},
      PEAP: {
        phase2: ["MSCHAPV2"]
      },
      TTLS: {
        phase2: ["MSCHAPV2"]
      },
      TLS: {}
    }
  }
}

Comment 8

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

(In reply to Chuck Lee [:chucklee] from comment #7)
> I think Phase 2 can be dynamic, too.
> 
> {
>   security: {
>     OPEN: {},
>     WEP: {},
>     WPA-PSK: {},
>     WPA-EAP: {
>       SIM: {},
>       PEAP: {
>         phase2: ["MSCHAPV2"]
>       },
>       TTLS: {
>         phase2: ["MSCHAPV2"]
>       },
>       TLS: {}
>     }
>   }
> }

If Gaia have a knowledge about UI should react with respect to the security method selected, maybe it can be simplified to the following structure:

Full capabilities:
{
  security: ["OPEN", "WEP", "WPA-PSK", "WPA-EAP"],
  eapMethods: ["SIM", "PEAP", "TTLS", "TLS"],
  eapPhase2: ["MSCHAPV2", "GTC"],
  certificates: ["SERVER", "USER", "PRIVATEKEY"]
}

And capabilities for Wifi in 2.0
{
  security: ["OPEN", "WEP", "WPA-PSK", "WPA-EAP"],
  eapMethods: ["SIM", "PEAP", "TTLS"],
  eapPhase2: ["MSCHAPV2"],
  certificates: ["SERVER"]
}

Comment 9

[Arthur Chen [:arthurcc][inactive after 6/30]]

Looks good to me!

Comment 10

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

Attachment: WIP - 0001. WebIDL Change.

Comment 11

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

Attachment: WIP - 0002. Provide capability info.

Comment 12

[Vincent Chang[:vchang][changyihsin]]

Comment on attachment 8419970 [details] [diff] [review]
WIP - 0002. Provide capability info.

Review of attachment 8419970 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.

Comment 13

[Blake Kaplan (:mrbkap) (inactive)]

This all looks really good.

Comment 14

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

Attachment: 0001. WebIDL Change.

Comment 15

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

Attachment: 0002. Provide capability info.

Comment 16

[(no longer active)]

Comment on attachment 8422167 [details] [diff] [review]
0001. WebIDL Change.

Review of attachment 8422167 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, Chuck!  Looks good.

Comment 17

[Vincent Chang[:vchang][changyihsin]]

Comment on attachment 8422168 [details] [diff] [review]
0002. Provide capability info.

Review of attachment 8422168 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.

Comment 18

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

Attachment: 0001. WebIDL Change. V2. r=ehsan,mrbkap

Add reviewers in comment and rebase.

Comment 19

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

Attachment: 0002. Provide capability info. V2. r=mrbkap,vchang

Add reviewers in comment and rebase.

Comment 20

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

Try : https://tbpl.mozilla.org/?tree=Try&rev=ea2acbf5997d

Comment 21

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

Try looks good.

Comment 22

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/a8eb0e4fba47

Should we have tests for this? :)
https://hg.mozilla.org/integration/b2g-inbound/rev/04193066a20c

Comment 23

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a8eb0e4fba47
https://hg.mozilla.org/mozilla-central/rev/04193066a20c

Comment 24

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

(In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #22)
> https://hg.mozilla.org/integration/b2g-inbound/rev/a8eb0e4fba47
> 
> Should we have tests for this? :)
> https://hg.mozilla.org/integration/b2g-inbound/rev/04193066a20c

Maybe we can add test in gaia-unit-test along with change in Settings app, I'll discuss with Gaia.