Closed
Bug 1002413
Opened 11 years ago
Closed 11 years ago
[Build] Refactor webapp-zip.js
Categories
(Firefox OS Graveyard :: Gaia::Build, defect)
Tracking
(feature-b2g:2.0)
People
(Reporter: gduan, Assigned: gduan)
References
Details
(Whiteboard: [p=3])
Attachments
(1 file)
1. Refactor webapp-zip.js
2. add tests
Assignee | ||
Comment 1•11 years ago
|
||
Assignee: nobody → gduan
Status: NEW → ASSIGNED
Assignee | ||
Updated•11 years ago
|
Whiteboard: [p=2]
Assignee | ||
Comment 2•11 years ago
|
||
waiting for travis.
Assignee | ||
Comment 3•11 years ago
|
||
Comment on attachment 8415076 [details] [review]
PR to master
Hi Yuren,
could you help me to review this patch?
thanks.
Attachment #8415076 -
Flags: review?(yurenju.mozilla)
Comment 4•11 years ago
|
||
Hi George, what goal do you want to achieve on this refactoring issue?
Assignee | ||
Comment 5•11 years ago
|
||
The refactoring goal is as below
1. make it more testable.
2. move xpcshell dependency to utils.
3. isolate main function (WebappZip) by webapp (see https://github.com/mozilla-b2g/gaia/pull/18768/files#diff-8d06cf2fa60a709d7fe1324030517ce8R229), so that it'll be easier to run async zip-app in the future.
Comment 6•11 years ago
|
||
Comment on attachment 8415076 [details] [review]
PR to master
After discussed with George, we can use middleware pattern to handle each job in |addToZip|, then we will have an very easy way to extend webapp-zip.
Thanks George!
Attachment #8415076 -
Flags: review?(yurenju.mozilla)
Assignee | ||
Updated•11 years ago
|
Target Milestone: --- → 2.0 S2 (23may)
Assignee | ||
Updated•11 years ago
|
Whiteboard: [p=2] → [p=3]
Assignee | ||
Comment 7•11 years ago
|
||
Comment on attachment 8415076 [details] [review]
PR to master
Hi Yuren,
as offline discussed, we should let this script do webapp-zip only after bug 1008114 has landed. So, I open bug 1010095 as follow-up.
Please kindly check this patch again. Thanks.
Attachment #8415076 -
Flags: review?(yurenju.mozilla)
Comment 8•11 years ago
|
||
Comment on attachment 8415076 [details] [review]
PR to master
this pr looks pretty good and after we solve bug 1010095 we will get a super clear webapp-zip :-)
good jog George!
Attachment #8415076 -
Flags: review?(yurenju.mozilla) → review+
Assignee | ||
Comment 9•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Updated•11 years ago
|
feature-b2g: --- → 2.0
You need to log in
before you can comment on or make changes to this bug.
Description
•