1002596 - Fix various sccache problems with clang

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mike Hommey [:glandium]]

I only tested the initial clang support in sccache worked with simple commands, but trying to build firefox revealed many issues:
- The compiler detection uses a c input, which clang++ complain about on stderr, and that fails because stderr is not opened for write when executing it.
- The -M* flags are given to both the preprocessor and the compiler, which breaks what ends up in depfiles because of the temporary source files for compilation. We only mean to use those flags on preprocessor.
- sccache doesn't know all flags clang supports that take a value, most notably -arch, we use during the build.
- clan.g tries to be smart with warnings, and may emit more of them when compiling preprocessed output, which, when combined with -Werror leads to build failures.
- ECONNREFUSED value is not the same as on Linux

Comment 1

[Mike Hommey [:glandium]]

Attachment: Fix various sccache problems with clang

Comment 2

[Michael Shal [:mshal]]

Comment on attachment 8413861 [details] [diff] [review]
Fix various sccache problems with clang

The clang -Werror issue is really unfortunate. Can you provide some details in this bug about it? Maybe it is something we could get fixed upstream eventually.

Comment 3

[Mike Hommey [:glandium]]

In file included from /builds/slave/try-osx64-d-000000000000000000/build/obj-firefox/security/certverifier/Unified_cpp_certverifier0.cpp:15:
/builds/slave/try-osx64-d-000000000000000000/build/security/certverifier/ExtendedValidation.cpp:839:36: error: self-comparison always evaluates to true [-Werror,-Wtautological-compare]
  unsigned int flags = (((trustSSL)==trustSSL)?((&nssTrust)->sslFlags): (((trustSSL)==trustEmail)?((&nssTrust)->emailFlags): (((trustSSL)==trustObjectSigning)?((&nssTrust)->objectSigningFlags):0)));
                                   ^
1 error generated.

Comment 4

[Mike Hommey [:glandium]]

https://github.com/glandium/sccache/commit/2f4c9a9850eca2e0e8eecccecebf29051a42918d