Closed Bug 1003011 Opened 7 years ago Closed 7 years ago

[B2G][RIL][Flame] Need to enable uicc subscription for flame dsds mode.

Categories

(Firefox OS Graveyard :: RIL, defect)

x86_64
Linux
defect
Not set
normal

Tracking

(blocking-b2g:1.4+, firefox30 wontfix, firefox31 wontfix, firefox32 fixed, b2g-v1.4 fixed, b2g-v2.0 fixed)

RESOLVED FIXED
2.0 S1 (9may)
blocking-b2g 1.4+
Tracking Status
firefox30 --- wontfix
firefox31 --- wontfix
firefox32 --- fixed
b2g-v1.4 --- fixed
b2g-v2.0 --- fixed

People

(Reporter: edgar, Assigned: edgar)

References

Details

(Whiteboard: [p=1])

Attachments

(2 files, 4 obsolete files)

The uicc subscription is off by default in flame, we need to enable uicc subscription after device bootup.
Blocks: 936325
(In reply to Edgar Chen [:edgar][:echen] from comment #0)
> The uicc subscription is off by default in flame, we need to enable uicc
> subscription after device bootup.

Otherwise, you will see device detected a sim card with AppIndex = -1.

04-23 21:08:10.635  4263  4289 I Gecko   : RIL Worker: [1] iccStatus: {"cardState":1,"universalPINState":0,"gsmUmtsSubscriptionAppIndex":-1,"cdmaSubscriptionAppIndex":-1,"imsSubscriptionAppIndex":-1,"apps":[{"app_type":2,"app_state":1,"perso_substate":0,"aid":"a0000000871002f886ff9289050b00ff","app_label":"000000","pin1_replaced":0,"pin1":0,"pin2":0}]}
Blocks: 994463
Attached patch WIP, patch, v1 (obsolete) — Splinter Review
Just a quick patch to make it work.
(In reply to Edgar Chen [:edgar][:echen] from comment #2)
> Created attachment 8414325 [details] [diff] [review]
> WIP, patch, v1
> 
> Just a quick patch to make it work.

Excellent! I confirm it works on my Flame with current master.
Attached patch Part 1: Cleanup RIL parcel, v1 (obsolete) — Splinter Review
can we get this work landed in master and 1.4 asap?
blocking-b2g: --- → 1.4?
Because uicc subscription control is flame specific behavior, we should add a new quirk for that. (ro.moz.ril.subscription_control)
Whiteboard: [p=1]
Target Milestone: --- → 2.0 S1 (9may)
Attached patch Part 1: Cleanup RIL parcel, v2 (obsolete) — Splinter Review
Attachment #8415141 - Attachment is obsolete: true
Attachment #8414325 - Attachment is obsolete: true
Attachment #8417256 - Flags: review?(htsai)
Attachment #8417257 - Flags: review?(htsai)
Comment on attachment 8417256 [details] [diff] [review]
Part 1: Cleanup RIL parcel, v2

Review of attachment 8417256 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/system/gonk/ril_worker.js
@@ +6393,5 @@
>    this.sendChromeMessage(options);
>  };
>  RilObject.prototype[RIL_REQUEST_GPRS_ATTACH] = null;
>  RilObject.prototype[RIL_REQUEST_GPRS_DETACH] = null;
> +RilObject.prototype[REQUEST_DIAL_EMERGENCY_CALL] = null;

Please rebase on the latest code, and keep what it is now, i.e. | RilObject.prototype[REQUEST_DIAL_EMERGENCY_CALL] = RilObject.prototype[REQUEST_DIAL];|
Attachment #8417256 - Flags: review?(htsai)
Address review comment #9.
Attachment #8417256 - Attachment is obsolete: true
Attachment #8417314 - Flags: review?(htsai)
Comment on attachment 8417314 [details] [diff] [review]
Part 1: Cleanup RIL parcel, v3

Review of attachment 8417314 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #8417314 - Flags: review?(htsai) → review+
Comment on attachment 8417257 [details] [diff] [review]
Part 2: Set uicc subscription, v1

Review of attachment 8417257 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good!

::: dom/system/gonk/ril_worker.js
@@ +3215,5 @@
>      let newCardState;
>      let index = this._isCdma ? iccStatus.cdmaSubscriptionAppIndex :
>                                 iccStatus.gsmUmtsSubscriptionAppIndex;
> +
> +    if (RILQUIRKS_SUBSCRIPTION_CONTROL && index === -1 && iccStatus.apps) {

The initial value of iccStatus.apps is [] which is guaranteed not null, so it's fine to disregard the condition |iccStatus.apps|. Please remove it, thanks.
Attachment #8417257 - Flags: review?(htsai) → review+
Need to add system property to enable this feature.

ro.moz.ril.subscription_control=true
Address review comment #12.
Attachment #8417257 - Attachment is obsolete: true
Attachment #8417815 - Flags: review+
NI :francis to confirm if we are going to have a 1.4 QC RIL available for flame in which case we may not need this.
Flags: needinfo?(mail)
We don't need to uplift this in 1.4.
blocking-b2g: 1.4? → -
Ken, it may be good to have this.  If the QC RIL fails, we can then fail over to the Mozril.  Otherwise we are completely broken for 1.4

Looping in mwu for comment; I could be mistaken.
Flags: needinfo?(mwu)
Flags: needinfo?(kchang)
Flags: needinfo?(bbajaj)
(In reply to Naoki Hirata :nhirata (please use needinfo instead of cc) from comment #20)
> Ken, it may be good to have this.  If the QC RIL fails, we can then fail
> over to the Mozril.  Otherwise we are completely broken for 1.4
We need MozRIL for main truck because some RIL/Telephony interfaces are changed in main truck and they cause that commercial RIL fails running with image of main truck.
For 1.4, Partner should be able to handle this. And I think Francis is pushing partner to do this. ni?francis
Flags: needinfo?(kchang) → needinfo?(frlee)
T2M will support 1.4 QC RIL, but it depends on QC's release date (for now, QC claims that they will focus on 8926 chipset instead of 8210) and T2M's porting effort. now, i'm pushing T2M to deal with QCT and see if there's any chance to pull in.
Nevertheless, it will never catch up our m-c release.

the main benefit of enabling MozRIL is that, we can use it for Flame's nightly build and it creates a completed developer friendly environment since Flame is Moz' reference phone.
Flags: needinfo?(frlee)
Flags: needinfo?(mwu)
Ken, based on the previous two comments can we have a reconsider of the 1.4 uplift please?
Flags: needinfo?(kchang)
guys, we really need this uplifted for 1.4.  we need to test the Flame device running with this configuration for the remaining 1.4 CS and other blockers.
blocking-b2g: - → 1.4?
(In reply to Naoki Hirata :nhirata (please use needinfo instead of cc) from comment #24)
> Ken, based on the previous two comments can we have a reconsider of the 1.4
> uplift please?
Sure, I am fine to do this if it is nominated as 1.4+ in triage meeting.
Flags: needinfo?(kchang)
blocking-b2g: 1.4? → 1.4+
You need to log in before you can comment on or make changes to this bug.