1003011 - [B2G][RIL][Flame] Need to enable uicc subscription for flame dsds mode.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: RIL, defect)

Description

[Edgar Chen [:edgar]]

The uicc subscription is off by default in flame, we need to enable uicc subscription after device bootup.

Comment 1

[Edgar Chen [:edgar]]

(In reply to Edgar Chen [:edgar][:echen] from comment #0)
> The uicc subscription is off by default in flame, we need to enable uicc
> subscription after device bootup.

Otherwise, you will see device detected a sim card with AppIndex = -1.

04-23 21:08:10.635  4263  4289 I Gecko   : RIL Worker: [1] iccStatus: {"cardState":1,"universalPINState":0,"gsmUmtsSubscriptionAppIndex":-1,"cdmaSubscriptionAppIndex":-1,"imsSubscriptionAppIndex":-1,"apps":[{"app_type":2,"app_state":1,"perso_substate":0,"aid":"a0000000871002f886ff9289050b00ff","app_label":"000000","pin1_replaced":0,"pin1":0,"pin2":0}]}

Comment 2

[Edgar Chen [:edgar]]

Attachment: WIP, patch, v1

Just a quick patch to make it work.

Comment 3

[:gerard-majax]

(In reply to Edgar Chen [:edgar][:echen] from comment #2)
> Created attachment 8414325 [details] [diff] [review]
> WIP, patch, v1
> 
> Just a quick patch to make it work.

Excellent! I confirm it works on my Flame with current master.

Comment 4

[Edgar Chen [:edgar]]

Attachment: Part 1: Cleanup RIL parcel, v1

Comment 5

[Tony Chung [:tchung]]

can we get this work landed in master and 1.4 asap?

Comment 6

[Edgar Chen [:edgar]]

Because uicc subscription control is flame specific behavior, we should add a new quirk for that. (ro.moz.ril.subscription_control)

Comment 7

[Edgar Chen [:edgar]]

Attachment: Part 1: Cleanup RIL parcel, v2

Comment 8

[Edgar Chen [:edgar]]

Attachment: Part 2: Set uicc subscription, v1

Comment 9

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Comment on attachment 8417256 [details] [diff] [review]
Part 1: Cleanup RIL parcel, v2

Review of attachment 8417256 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/system/gonk/ril_worker.js
@@ +6393,5 @@
>    this.sendChromeMessage(options);
>  };
>  RilObject.prototype[RIL_REQUEST_GPRS_ATTACH] = null;
>  RilObject.prototype[RIL_REQUEST_GPRS_DETACH] = null;
> +RilObject.prototype[REQUEST_DIAL_EMERGENCY_CALL] = null;

Please rebase on the latest code, and keep what it is now, i.e. | RilObject.prototype[REQUEST_DIAL_EMERGENCY_CALL] = RilObject.prototype[REQUEST_DIAL];|

Comment 10

[Edgar Chen [:edgar]]

Attachment: Part 1: Cleanup RIL parcel, v3

Address review comment #9.

Comment 11

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Comment on attachment 8417314 [details] [diff] [review]
Part 1: Cleanup RIL parcel, v3

Review of attachment 8417314 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 12

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Comment on attachment 8417257 [details] [diff] [review]
Part 2: Set uicc subscription, v1

Review of attachment 8417257 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good!

::: dom/system/gonk/ril_worker.js
@@ +3215,5 @@
>      let newCardState;
>      let index = this._isCdma ? iccStatus.cdmaSubscriptionAppIndex :
>                                 iccStatus.gsmUmtsSubscriptionAppIndex;
> +
> +    if (RILQUIRKS_SUBSCRIPTION_CONTROL && index === -1 && iccStatus.apps) {

The initial value of iccStatus.apps is [] which is guaranteed not null, so it's fine to disregard the condition |iccStatus.apps|. Please remove it, thanks.

Comment 13

[Edgar Chen [:edgar]]

Need to add system property to enable this feature.

ro.moz.ril.subscription_control=true

Comment 14

[Edgar Chen [:edgar]]

Attachment: Part 2: Set uicc subscription, v2, r=hsinyi

Address review comment #12.

Comment 15

[Edgar Chen [:edgar]]

Try result: https://tbpl.mozilla.org/?tree=Try&rev=af51c8e0cf77

Comment 16

[Edgar Chen [:edgar]]

https://hg.mozilla.org/integration/b2g-inbound/rev/e439a65adc0b
https://hg.mozilla.org/integration/b2g-inbound/rev/69b17f30b7ec

Comment 17

[bhavana bajaj [:bajaj]]

NI :francis to confirm if we are going to have a 1.4 QC RIL available for flame in which case we may not need this.

Comment 18

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e439a65adc0b
https://hg.mozilla.org/mozilla-central/rev/69b17f30b7ec

Comment 19

[Ken Chang[:kenkai]]

We don't need to uplift this in 1.4.

Comment 20

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Ken, it may be good to have this.  If the QC RIL fails, we can then fail over to the Mozril.  Otherwise we are completely broken for 1.4

Looping in mwu for comment; I could be mistaken.

Comment 21

[Ken Chang[:kenkai]]

(In reply to Naoki Hirata :nhirata (please use needinfo instead of cc) from comment #20)
> Ken, it may be good to have this.  If the QC RIL fails, we can then fail
> over to the Mozril.  Otherwise we are completely broken for 1.4
We need MozRIL for main truck because some RIL/Telephony interfaces are changed in main truck and they cause that commercial RIL fails running with image of main truck.
For 1.4, Partner should be able to handle this. And I think Francis is pushing partner to do this. ni?francis

Comment 22

[Francis Lee [:frlee]]

T2M will support 1.4 QC RIL, but it depends on QC's release date (for now, QC claims that they will focus on 8926 chipset instead of 8210) and T2M's porting effort. now, i'm pushing T2M to deal with QCT and see if there's any chance to pull in.
Nevertheless, it will never catch up our m-c release.

the main benefit of enabling MozRIL is that, we can use it for Flame's nightly build and it creates a completed developer friendly environment since Flame is Moz' reference phone.

Comment 24

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Ken, based on the previous two comments can we have a reconsider of the 1.4 uplift please?

Comment 25

[Tony Chung [:tchung]]

guys, we really need this uplifted for 1.4.  we need to test the Flame device running with this configuration for the remaining 1.4 CS and other blockers.

Comment 26

[Ken Chang[:kenkai]]

(In reply to Naoki Hirata :nhirata (please use needinfo instead of cc) from comment #24)
> Ken, based on the previous two comments can we have a reconsider of the 1.4
> uplift please?
Sure, I am fine to do this if it is nominated as 1.4+ in triage meeting.

Comment 27

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g30_v1_4/rev/c68205b308df
https://hg.mozilla.org/releases/mozilla-b2g30_v1_4/rev/ae1ef724923d