1003107 - Remove reflow logging from the webconsole

Status: NEW

(DevTools :: Console, task, P3)

Description

[Patrick Brosset <:pbro>]

Bug 997198 brings a new Reflow actor that sends events when reflows occur.

The web console already observes reflows on the server-side (http://mxr.mozilla.org/mozilla-central/source/toolkit/devtools/webconsole/utils.js#1687).

Instead of adding 2 observers, we should just use the new actor.
So, either the web console instantiates a new front to track reflows, or we put the existing front (instantiated by the layoutview) in common.

Comment 1

[Patrick Brosset <:pbro>]

I might work on this. Important things to keep in mind:
- the webconsole needs more information than what the reflowactor currently exposes: filename, lineNumber, ...
- we need to make sure events are sent only once from the actor to the front, in other words, there should only be one shared front in the toolbox

Comment 2

[Paul Rouget [:paul]]

We show reflows in the webconsole because there were no better place. But now the timeline is coming, I would just kill this feature.

Comment 3

[Patrick Brosset <:pbro>]

(In reply to Paul Rouget [:paul] (slow to respond. Ping me on IRC) from comment #2)
> We show reflows in the webconsole because there were no better place. But
> now the timeline is coming, I would just kill this feature.

You're right, I didn't think of that. Better not work on this bug then.

Comment 4

[Brian Grinstead [:bgrins]]

There are new webconsole filtering designs in flight that may give us a reason to remove this feature from the console

Comment 5

[Lin Clark [:linclark]]

We should probably decide on this before tackling https://github.com/devtools-html/gecko-dev/issues/198

Comment 6

[Brian Grinstead [:bgrins]]

Discussed on the list: https://groups.google.com/d/msg/mozilla.dev.developer-tools/LU3_mcyUfdE/NQavwYARAwAJ.  Let's proceed with removing the feature in this bug.  There's the server piece, filter button UI and pref, handleReflowActivity callbacks in client/webconsole.js, and any tests.

Comment 7

[Jan Honza Odvarko [:Honza] (always need-info? me)]

@Evan, can you please take a look at this bug?

Honza

Comment 8

[Evan Tseng [:evanxd]]

Hi Honza,

Sorry for that. In the mean time, I don't have time for the bug. We might need to find another contributor to fix it.

Once I have time for dev tools, I'll be back.