Closed Bug 1003752 Opened 11 years ago Closed 11 years ago

[VR][Contacts] "Select all" and "Deselect all" buttons shouldn't appear in "Delete contacts" screen

Categories

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Contacts
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(b2g-v2.0 fixed)

Status:
VERIFIED FIXED
Milestone:
2.0 S1 (9may)
Tracking Flags:
Tracking Status
b2g-v2.0 --- fixed

People

(Reporter: lolimartinezcr, Assigned: crdlc)

References

Details

Attachments

(1 file)

Patch v1
190 bytes, text/html
jmcf
: review+
Details
Tested 1.5 Hamachi Gecko: 13b2542 Gaia: 08ea844 Reproducible: 100% STR 1) Tap contacts aplication. 2) Tap Settings. 3) Tap "Delete contacts" 4) Tap "Search" Actual result: Search screen with "Deselect all" and "Select all" buttons Expected result: Search screen with *NOT* "Deselect all" and "Select all" buttons
Blocks: 990478
Assignee: nobody → crdlc
Status: NEW → ASSIGNED
Attached file Patch v1 —
Added the same behavior than header
Attachment #8415167 - Flags: review?(jmcf)
Comment on attachment 8415167 [details] Patch v1 works perfectly, maybe we can add a test case for this
Attachment #8415167 - Flags: review?(jmcf) → review+
blocking-b2g: --- → 2.0?
status-b2g-v2.0: --- → affected
I just changed some CSS rules, so the only way to demonstrate that it is working fine is making an integration test thought :) (In reply to Jose Manuel Cantera from comment #2) > Comment on attachment 8415167 [details] > Patch v1 > > works perfectly, maybe we can add a test case for this
Merged in master: https://github.com/mozilla-b2g/gaia/commit/36ba757723f308afa7094044aa44c2fe75c46d37
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
blocking-b2g: 2.0? → ---
status-b2g-v2.0: affected → fixed
Target Milestone: --- → 2.0 S1 (9may)
Reverted for Gaia integration test failures on TBPL. Master: https://github.com/mozilla-b2g/gaia/commit/8873166797fecfa65c0afa644d2ebcc7d7cb4ed3 https://tbpl.mozilla.org/php/getParsedLog.php?id=38816899&tree=B2g-Inbound
Status: RESOLVED → REOPENED
status-b2g-v2.0: fixed → ---
Resolution: FIXED → ---
Target Milestone: 2.0 S1 (9may) → ---
Merged in master: https://github.com/mozilla-b2g/gaia/commit/7237fb7042197befc42789527d6431ca054e96b6
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
status-b2g-v2.0: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 2.0 S1 (9may)
Blocks: 1004929
The integration test was skipped and it will be fixed in bug 1004929
Tested and working 1.5 Hamachi Gecko: 6fafefc Gaia: 0d705e6
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: