990478 - Replace confirm [BB] with edit mode [BB] in [Contacts]

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Attachment: delete_contacts_list.png

Some screens in Contacts app are not using the proper BB as seen in the attached file "delete_contacts_list.png".
We should use settings header and white footer.

Comment 1

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Attachment: patch in github

Comment 2

[Jose Manuel Cantera]

Attachment: 18239.html

The initial patch from Arnau refined and adapted to pass unit tests

Comment 3

[Francisco Jordano [:arcturus] [:francisco]]

Hei Jose,

I'm seeing a weird effect when we move the the edit mode, (using the delete button). Like an orange header appearing and disappearing.

Comment 4

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Comment on attachment 8405421 [details]
18239.html

Jose Manuel, in that case to avoid the flicker in the animation, what make sense to me is:
-Add to settings view a z-index higher than edit mode (>100).
-After tapping on remove button, move the seetings view down (same animation as when tapping on reset)
-It will show contacts list again, but this time with edit mode overlay :)

Make sense?

Comment 5

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8405421 [details]
18239.html

Unassigning review till problems noticed solved

Comment 6

[Jose Manuel Cantera]

Comment on attachment 8405421 [details]
18239.html

now we are talking. approaching to a better solution for edit / selection mode.

Comment 7

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Comment on attachment 8405421 [details]
18239.html

Love it!
Awesome job Jose Manuel :)

Comment 8

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8405421 [details]
18239.html

Code wise LGTM, just left couple of comments on github and one extra thing.

Just one question that I left on github as well, the checkboxes when entering the delete are not red, are they suppose to be fixed in this PR?

Thanks!

Comment 9

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8405421 [details]
18239.html

r+ once fixed the comment on gh, also travis green.

Please double check with UX if after leaving the edit mode we should stay on the list or we should stay on settings.

Thanks!

Comment 10

[Jose Manuel Cantera]

https://github.com/jmcanterafonseca/gaia/commit/592fbc1451412d151c67bbca863e8ab9bfd54feb

Comment 11

[Loli (:lolimartinezcr)]

Bug 1003752 verified, for this reason it is verified.