1003856 - Selecting address from recipient autocomplete broken for all scenarios except {Name beginsWith} topmost match (selecting from dropdown list disfunctional)

Status: VERIFIED FIXED

(Thunderbird :: Message Compose Window, defect)

Description

[Onno Ekker [:nONoNonO UTC+1]]

When you compose a new mail and start typing an email address, you get a autocompletion drop-down pick list.

If you use the arrow keys to move to another entry and then press Enter, the first recipient is still shown.

Also when you start typing something from the middle of an email address, it is shown as [typed text] >> [autocompletion result]. When you select that address, the suggestion stays there, for example:
"ekker >> Onno Ekker <[e-mail]>"

This last error might be the same as in bug 749923 for Firefox.

Comment 1

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Last good: 20140427
First bad: 20140428

Regression from bug 959209

Comment 2

[Wayne Mery (:wsmwk)]

I suggest we will want to, relatively soon, land the fix for this on 31/aurora

Comment 3

[Thomas D. (:thomas8)]

(In reply to Wayne Mery (:wsmwk) from comment #2)
> I suggest we will want to, relatively soon, land the fix for this on
> 31/aurora

+1, definitely so. Bugs like this will make TB a laughing stock.

Comment 4

[Thomas D. (:thomas8)]

Adjusting summary to match realities on Trunk (32.0a1 (2014-05-01)).

If the behaviour is different on 31/Aurora, feel free to revert summary as appropriate, and let me know if separate bug is needed for Trunk.

Comment 5

[[:MakeMyDay]]

Attendee autocomplete in calendar is affected thereby as well (becomes obvious with the patch to bug 1002611 applied).

Comment 6

[Magnus Melin [:mkmelin]]

Have a patch for this. It's fallout from bug 754265 when landed in between the patch creation for bug 959209 and landing...

Comment 8

[Magnus Melin [:mkmelin]]

Lets not track bug bug 749923 in here, though that is easily reproducible with toolkit autocomplete.

Comment 9

[Magnus Melin [:mkmelin]]

Attachment: proposed fix

Adds getFinalCompleteValueAt.

Comment 10

[Thomas D. (:thomas8)]

Does this fix similar bug 348844?

Comment 11

[Mark Banner (:standard8)]

Comment on attachment 8416933 [details] [diff] [review]
proposed fix

Great, thanks r=Standard8.

I'll pre-approve this for Aurora as well, as we definitely want this there.

Comment 12

[Magnus Melin [:mkmelin]]

(In reply to Thomas D. from comment #10)
> Does this fix similar bug 348844?

Not directly, that's some bug in the autocomplete widget(s)

Comment 13

[Magnus Melin [:mkmelin]]

https://hg.mozilla.org/comm-central/rev/5c08b80e0daf -> FIXED

Comment 15

[Mark Banner (:standard8)]

Just realised I'd managed to leave aurora closed, so I've just landed this in time for today's builds:

https://hg.mozilla.org/releases/comm-aurora/rev/b3744e4ffff0