1003898 - Ensure all AWS buildbot masters are in inventory

Status: RESOLVED FIXED

(Infrastructure & Operations Graveyard :: CIDuty, task, P2)

Description

[Justin Wood (:Callek)]

Per :dustin,

AWS Buildbot Masters should *all* be in inventory, especially because as we add/move/whatever slaves we'll be missing flows whenever we need flows to "all buildbot masters"

Assigning to ben initially as he added bm01->04 which are currently not in inventory. feel free to reassign though

Comment 1

[[e-mail] (:bhearsum)]

I don't think there was any buildbot masters in the "systems" section of inventory when I created these.

AFAIK, we don't add AWS machines to that section in the first place. If that's changed, that's fine - but we probably have some docs/scripts to update in that case.

Comment 2

[Rail Aliiev [:rail]]

We don't usually add slaves to the "systems" section, only to DNS. In the nearest future it won't be necessary.

AFAIK, we may need to have the masters in the inventory to simplify netflow bugs. I'd rather not have them in the "system" section unless we have tools to add/remove masters.

Comment 3

[Chris AtLee [:catlee]]

We've not done this previously. If netops is working on some magic to let us manage flows to "all buildbot masters" that requires us to put them into inventory, that's great. Otherwise, is there an immediate benefit to this?

Comment 4

[Dustin J. Mitchell [:dustin] (he/him)]

Well, currently there are *some* masters in inventory, which led me to suggest those for a flow request.  I think we can agree we should be consistent.

If AWS masters are *not* in inventory, then I'm not sure how best to manage flows for them, as that leaves me without a reliable common source of information about what the current set of Buildbot masters is.

Comment 5

[[e-mail] (:bhearsum)]

I added buildbot-master01 through 06 to the system sections. I'm not sure if there's more missing, but those are the ones I created.

Comment 6

[Chris Cooper [:coop] (he/him)]

All masters are in inventory already, but based on the current contents of production-masters.json, there are some that need to be removed:

> buildbot-master55.srv.releng.use1.mozilla.com
> buildbot-master56.srv.releng.usw2.mozilla.com
> buildbot-master57.srv.releng.use1.mozilla.com
> buildbot-master58.srv.releng.usw2.mozilla.com
> buildbot-master59.srv.releng.use1.mozilla.com
> buildbot-master60.srv.releng.usw2.mozilla.com
> buildbot-master61.srv.releng.use1.mozilla.com
> buildbot-master62.srv.releng.use1.mozilla.com
> buildbot-master63.srv.releng.use1.mozilla.com
> buildbot-master64.srv.releng.usw2.mozilla.com
> buildbot-master65.srv.releng.usw2.mozilla.com
> buildbot-master66.srv.releng.usw2.mozilla.com
> buildbot-master80.srv.releng.usw2.mozilla.com
> buildbot-master90.srv.releng.use1.mozilla.com
> buildbot-master92.srv.releng.use1.mozilla.com
> buildbot-master93.srv.releng.usw2.mozilla.com
> buildbot-master95.srv.releng.usw2.mozilla.com
> buildbot-master96.srv.releng.use1.mozilla.com
> buildbot-master97.srv.releng.usw2.mozilla.com
> buildbot-master98.srv.releng.use1.mozilla.com

Comment 7

[Chris Cooper [:coop] (he/him)]

These have all been removed from inventory.

Comment 8

[Amy Rich [:arr] [:arich]]

buildbot-master66.srv.releng.usw2.mozilla.com added back since it's actually running stuff, just not buildbot.