Closed
Bug 1003970
Opened 11 years ago
Closed 11 years ago
Tagging comments not shown in user activity
Categories
(bugzilla.mozilla.org :: General, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: Dolske, Assigned: dylan)
References
Details
Attachments
(1 file, 1 obsolete file)
3.31 KB,
patch
|
glob
:
review+
|
Details | Diff | Splinter Review |
I tagged some comments this morning, but I don't see any indication of doing so in my results in https://bugzilla.mozilla.org/page.cgi?id=user_activity.html
Not a big deal, but I use the page frequently to see what random people have been up to, and it would be good to help see if someone's been twiddling tags.
![]() |
||
Updated•11 years ago
|
Assignee: create-and-change → nobody
Component: Creating/Changing Bugs → Extensions: UserProfile
OS: Mac OS X → All
Product: Bugzilla → bugzilla.mozilla.org
QA Contact: default-qa
Hardware: x86 → All
Version: unspecified → Production
dylan's working on bringing user-activity upstream in bug 387586 and i remember discussing this issue with him for the upstream work. i suspect it would be a simple fix for our custom report.
Assignee: nobody → dylan
Component: Extensions: UserProfile → General
Assignee | ||
Comment 2•11 years ago
|
||
This will be fixed by backporting the fix in bug 387586
Assignee | ||
Updated•11 years ago
|
Status: NEW → ASSIGNED
(In reply to Dylan William Hardison [:dylan] from comment #2)
> This will be fixed by backporting the fix in bug 387586
true, however that's a large change, and isn't ready yet.
can you quickly bring in just the comment-tags part of the query?
Assignee | ||
Comment 4•11 years ago
|
||
It is just a paragraph of SQL in a UNION ALL, I'll fix this now,
Assignee | ||
Comment 5•11 years ago
|
||
Add comments to user activity report, mostly just a SQL statement.
Attachment #8425324 -
Flags: review?(dkl)
Assignee | ||
Comment 6•11 years ago
|
||
Comment on attachment 8425324 [details] [diff] [review]
bug-1003970-v1.patch
Actually, it makes more sense to r? glob, as this is related to the other bug he reviewed.
Attachment #8425324 -
Flags: review?(dkl) → review?(glob)
Comment on attachment 8425324 [details] [diff] [review]
bug-1003970-v1.patch
Review of attachment 8425324 [details] [diff] [review]:
-----------------------------------------------------------------
this looks great and works well, however i think it would be much more useful if the 'what' column linked to the comment that was tagged:
[% ELSIF change.comment.defined && change.fieldname == 'comment_tag' %]
[% "Comment $change.comment.count Tagged"
FILTER bug_link(operation.bug, comment_num => change.comment.count)
FILTER none %]
Attachment #8425324 -
Flags: review?(glob) → review-
Assignee | ||
Comment 8•11 years ago
|
||
Do you reckon we should show which tag was added/removed in addition to the link to the comment?
(In reply to Dylan William Hardison [:dylan] from comment #8)
> Do you reckon we should show which tag was added/removed in addition to the
> link to the comment?
the tag is already visible in the added or removed column.
Assignee | ||
Comment 10•11 years ago
|
||
Of course it is, but not if you add that code to the change column.
Assignee | ||
Comment 11•11 years ago
|
||
Attachment #8425324 -
Attachment is obsolete: true
Attachment #8428140 -
Flags: review?(glob)
Assignee | ||
Comment 12•11 years ago
|
||
This looks much nicer, I'm also porting to bug 387586
Comment 13•11 years ago
|
||
Comment on attachment 8428140 [details] [diff] [review]
bug-1003970-v2.patch
Review of attachment 8428140 [details] [diff] [review]:
-----------------------------------------------------------------
r=glob
Attachment #8428140 -
Flags: review?(glob) → review+
Assignee | ||
Comment 14•11 years ago
|
||
To gitolite3@git.mozilla.org:webtools/bmo/bugzilla.git
049ea3d..da0dd84 master -> master
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•