1003970 - Tagging comments not shown in user activity

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: General, defect)

Description

[Justin Dolske [:Dolske]]

I tagged some comments this morning, but I don't see any indication of doing so in my results in https://bugzilla.mozilla.org/page.cgi?id=user_activity.html

Not a big deal, but I use the page frequently to see what random people have been up to, and it would be good to help see if someone's been twiddling tags.

Comment 1

[:glob ✱]

dylan's working on bringing user-activity upstream in bug 387586 and i remember discussing this issue with him for the upstream work.  i suspect it would be a simple fix for our custom report.

Comment 2

[Dylan Hardison [:dylan] (he/him)]

This will be fixed by backporting the fix in bug 387586

Comment 3

[:glob ✱]

(In reply to Dylan William Hardison [:dylan] from comment #2)
> This will be fixed by backporting the fix in bug 387586

true, however that's a large change, and isn't ready yet.

can you quickly bring in just the comment-tags part of the query?

Comment 4

[Dylan Hardison [:dylan] (he/him)]

It is just a paragraph of SQL in a UNION ALL, I'll fix this now,

Comment 5

[Dylan Hardison [:dylan] (he/him)]

Attachment: bug-1003970-v1.patch

Add comments to user activity report, mostly just a SQL statement.

Comment 6

[Dylan Hardison [:dylan] (he/him)]

Comment on attachment 8425324 [details] [diff] [review]
bug-1003970-v1.patch

Actually, it makes more sense to r? glob, as this is related to the other bug he reviewed.

Comment 7

[:glob ✱]

Comment on attachment 8425324 [details] [diff] [review]
bug-1003970-v1.patch

Review of attachment 8425324 [details] [diff] [review]:
-----------------------------------------------------------------

this looks great and works well, however i think it would be much more useful if the 'what' column linked to the comment that was tagged:

  [% ELSIF change.comment.defined && change.fieldname == 'comment_tag' %]
    [% "Comment $change.comment.count Tagged"
      FILTER bug_link(operation.bug, comment_num => change.comment.count)
      FILTER none %]

Comment 8

[Dylan Hardison [:dylan] (he/him)]

Do you reckon we should show which tag was added/removed in addition to the link to the comment?

Comment 9

[:glob ✱]

(In reply to Dylan William Hardison [:dylan] from comment #8)
> Do you reckon we should show which tag was added/removed in addition to the
> link to the comment?

the tag is already visible in the added or removed column.

Comment 10

[Dylan Hardison [:dylan] (he/him)]

Of course it is, but not if you add that code to the change column.

Comment 11

[Dylan Hardison [:dylan] (he/him)]

Attachment: bug-1003970-v2.patch

Comment 12

[Dylan Hardison [:dylan] (he/him)]

This looks much nicer, I'm also porting to bug 387586

Comment 13

[:glob ✱]

Comment on attachment 8428140 [details] [diff] [review]
bug-1003970-v2.patch

Review of attachment 8428140 [details] [diff] [review]:
-----------------------------------------------------------------

r=glob

Comment 14

[Dylan Hardison [:dylan] (he/him)]

To [e-mail]:webtools/bmo/bugzilla.git
   049ea3d..da0dd84  master -> master