1004229 - "TypeError: lastCommentDiv.parentNode is null" from inline history when the last comment is a 'duplicate' comment

Status: RESOLVED FIXED

(bugzilla.mozilla.org Graveyard :: Extensions: InlineHistory, defect)

Description

[:Gijs (he/him)]

e.g. bug 984589 doesn't show the reopening or the original marking as a duplicate.

The console shows:

TypeError: lastCommentDiv.parentNode is null

from

lastCommentDiv.parentNode.insertBefore(currentDiv, lastCommentDiv.nextSibling);


in inline-history:137

Comment 1

[:glob ✱]

odd.  i see the resolution change and there's no javascript error.

Comment 2

[:glob ✱]

gijs, do you have any firefox addons which interact with bugzilla installed (eg. bugzillaJS) ?

Comment 3

[:Gijs (he/him)]

(In reply to Byron Jones ‹:glob› from comment #2)
> gijs, do you have any firefox addons which interact with bugzilla installed
> (eg. bugzillaJS) ?

No, and I can reproduce both on OS X and Windows (tested in safe mode on windows to be sure, but I only have DOMI installed in that profile), both with Fx 29.

Comment 4

[:glob ✱]

this appears to be account related -- with gijs's permission i impersonated him and was able to replicate the issue.  i'll investigate this further.

Comment 5

[:glob ✱]

this happens when the last comment on the page is a 'NNN has been marked as a duplicate of this bug' comment.  the div is removed by inline-history, but is later used to append new items to the end of the activity stream.

i wasn't seeing this issue because gijs's comment sorting order is different from mine.

Comment 6

[:glob ✱]

To ssh://[e-mail]/webtools/bmo/bugzilla.git
   261f42c..01350d7  master -> master