Sideways sliding animation in panels should be disabled when prefers-reduced-motion is turned on
Categories
(Firefox :: Menus, defect, P3)
Tracking
()
Tracking | Status | |
---|---|---|
firefox112 | --- | verified |
People
(Reporter: u501112, Assigned: amy)
References
(Blocks 1 open bug, Regressed 1 open bug)
Details
(Keywords: access, Whiteboard: [fidefe-quality-foundation] )
Attachments
(1 file)
Comment 2•11 years ago
|
||
Comment 4•11 years ago
|
||
Comment 6•11 years ago
|
||
Comment 8•11 years ago
|
||
Updated•11 years ago
|
Reporter | ||
Comment 10•11 years ago
|
||
Comment 11•11 years ago
|
||
Comment 12•11 years ago
|
||
Reporter | ||
Comment 13•11 years ago
|
||
Comment 14•11 years ago
|
||
Updated•11 years ago
|
Comment 15•11 years ago
|
||
Reporter | ||
Comment 16•11 years ago
|
||
Comment 17•11 years ago
|
||
Reporter | ||
Comment 18•11 years ago
|
||
Comment 19•11 years ago
|
||
Reporter | ||
Comment 20•11 years ago
|
||
Reporter | ||
Comment 21•11 years ago
|
||
Comment 22•11 years ago
|
||
Reporter | ||
Comment 23•11 years ago
|
||
Reporter | ||
Comment 24•11 years ago
|
||
Reporter | ||
Comment 25•11 years ago
|
||
Comment 26•11 years ago
|
||
Comment 27•11 years ago
|
||
Reporter | ||
Comment 28•11 years ago
|
||
Comment 29•11 years ago
|
||
![]() |
||
Comment 30•11 years ago
|
||
Comment 31•11 years ago
|
||
Comment 32•11 years ago
|
||
Comment 33•11 years ago
|
||
Comment 34•11 years ago
|
||
Comment 35•11 years ago
|
||
Updated•11 years ago
|
Comment 36•11 years ago
|
||
Comment 37•10 years ago
|
||
Comment 38•10 years ago
|
||
Comment 39•10 years ago
|
||
Comment 41•8 years ago
|
||
Comment 42•8 years ago
|
||
Comment 44•5 years ago
|
||
Should these userChrome.css modifications still work in 71.0? I've got:
toolkit.legacyUserProfileCustomizations.stylesheets = true
...but none of these modifications seem to work.
My userChrome.css is just as follows:
@namespace url("http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul");
.panel-arrowcontainer {
opacity: 1;
transform: none;
pointer-events: all !important;
}
Comment 45•5 years ago
|
||
I don't think they use xul any more. Try commenting out the namespace line and see if that helps.
Comment 46•5 years ago
•
|
||
(In reply to MarjaE from comment #45)
I don't think they use xul any more. Try commenting out the namespace line and see if that helps.
I posted over in the Mozillazine forums, and it turns out that all the modifications I was trying were out of date (including the specific one above). You're right that the namespace line was unnecessary, but that wasn't the cause of the problem. It looks like the modifications in this bug report need changes, but I'm not knowledgeable enough about Firefox CSS code to make the changes. If I get something that works, I'll report back.
Comment 47•5 years ago
|
||
Found a solution. It looks like it's as easy as setting xul.panel-animations.enabled to false.
Comment 48•5 years ago
|
||
Thank you. This fixed the drop down animations.
However, the sideways animation in the main menu, when clicking a menu item that leads to a submenu, is still there.
Updated•3 years ago
|
Comment 49•3 years ago
|
||
The opening of the panels now obeys your OS's "reduce motion" preference, which can also be set in Firefox's about:config with ui.prefersReducedMotion
(numeric pref, set to 1 to prevent animations).
This doesn't appear to impact the sideways sliding of subview, so I've morphed the bug to cover that.
Updated•2 years ago
|
Updated•2 years ago
|
Updated•2 years ago
|
Assignee | ||
Updated•2 years ago
|
Assignee | ||
Comment 50•2 years ago
|
||
Comment 51•2 years ago
|
||
The css in comment 38 no longer works. So for the only css I've found which blocks the animation is either:
/* De-Animate /
/ Note: this disables certain menus. */
@namespace url(http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul);
- { transition: none !important;
animation-duration: 0s !important; } - { transition:unset !important; }
or:
/* Remove some Random Annoying Animations in the Toolbar, from this author : annoying animations https://www.reddit.com/r/firefox/comments/37hw8o/how_to_disable_all_animations/ /
/ Note: this disables certain menus. */
- {
animation-delay: 0ms !important;
animation-duration: 0ms !important;
transition: none !important;
}
Both of which not only block the animation, but disable the menus.
Reducing Firefox's frame rate to 1/second still has the menus flash, although at least they don't smoothly animate. Ideally, the menus should work regardless of user css to block other, unrelated, animation.
Comment 52•2 years ago
|
||
Comment 53•2 years ago
|
||
Backed out for causing multiple failures
-
Failure line: TEST-UNEXPECTED-FAIL | browser/components/enterprisepolicies/tests/browser/browser_policy_support_menu.js | Test timed out -
-
Failure line: TEST-UNEXPECTED-FAIL | browser/base/content/test/general/browser_addCertException.js | Test timed out -
-
Failure line:TEST-UNEXPECTED-FAIL | devtools/server/tests/chrome/test_styles-applied.html | Should have the expected number of rules. - got 10, expected 9
Assignee | ||
Comment 54•2 years ago
|
||
Hi Molly, I think I am missing something -- I took a look at these test failures and it is not obvious to me how to adjust this patch to fix them, or why they are even failing?
Failure line:TEST-UNEXPECTED-FAIL | devtools/server/tests/chrome/test_styles-applied.html | Should have the expected number of rules. - got 10, expected 9
^ in particular is confusing me. Do you understand what is happening here, by chance?
Comment 55•2 years ago
|
||
(In reply to Amy Churchwell [:amy] from comment #54)
Hi Molly, I think I am missing something -- I took a look at these test failures and it is not obvious to me how to adjust this patch to fix them, or why they are even failing?
Failure line:TEST-UNEXPECTED-FAIL | devtools/server/tests/chrome/test_styles-applied.html | Should have the expected number of rules. - got 10, expected 9
^ in particular is confusing me. Do you understand what is happening here, by chance?
I looked up that test and immediately I see this comment:
// If our system stylesheets are prone to churn, this might be a fragile
// test. If you're here because of that I apologize, file a bug
// and we can find a different way to test.
So yeah, I think that's the situation we've hit here, adding a rule to xul.css must have caused this count to increase. Bumping the expected value to 10 does indeed make the test pass, and that might be the right short term solution, but I think it's worth pinging nchevobbe to discuss this before landing anything here.
The other two tests are both timing out waiting for ViewShown
events, even though the correct view is actually showing, which seems strange. So I looked up where that event is generated to see what might cause it to not be, and the only thing I could see that leads to that _activateView
function not being called would be this async call doing something unexpected. Which it is, right here; that transitionend
won't happen if there's no transition, so that immediately-awaited promise doesn't resolve. So the solution for these two tests I think would be to avoid setting the transform
property there in _transitionViews
at all when prefers-reduced-motion is set. Which, and this is a bit awkward, I think might make the entire current patch unnecessary? Although I guess that would also fix the devtools test, so there's that.
Assignee | ||
Updated•2 years ago
|
Comment 56•2 years ago
|
||
Comment 57•2 years ago
|
||
Backed out changeset a55825557cf0 (Bug 984589) for bc failures on browser_identityPopup_focus.js.
Backout link
Push with failures <--> bc2
Failure Log
Comment 58•2 years ago
|
||
Assignee | ||
Updated•2 years ago
|
Comment 59•2 years ago
|
||
bugherder |
Updated•2 years ago
|
Comment 60•2 years ago
|
||
I've reproduced the issue on Nightly 112.0a1 (2023-02-28) on Windows 10, macSO 13 and Ubuntu 22.04.
The issue is no longer reproducible on Nightly 113.0a1 (2023-04-02) on the same system.
I've checked following slide menus: Bookmarks, History, More tools and Help(from hamburger menu and customized toolbar).
I've tested using pref "ui.prefersReducedMotion" set to 1 and without the pref.
Also I've tested by disabling the Animations on my computer:
Windows 10
Show animations in Windows: off
or unchecking following options in Advanced System Settings
Animate controls and elements inside windows
- Animate windows when minimizing and maximizing*
Animations in the taskbar
macOS 13
Reduce Motion: on
Ubuntu 22.04
Enable Animations: off
Updated•2 years ago
|
Updated•2 years ago
|
Description
•