1004421 - CSS issues in cleopatra

Status: RESOLVED WONTFIX

(DevTools :: Performance Tools (Profiler/Timeline), defect)

Description

[:Gijs (he/him)]

Found by bug 971096:

Unknown property 'user-select'.  Declaration dropped. 
browser/devtools/profiler/cleopatra/css/tree.css, line: 7 column: 13 source: "  user-select: none;"

Expected color but found 'left'.  Error in parsing value for 'background'.  Declaration dropped.
browser/devtools/profiler/cleopatra/css/tree.css, line: 98 column: 30 source: "  background: linear-gradient(left, transparent, transparent 98px, #CCC 98px, #CCC 99px, transparent 99px),"

Unknown property 'user-select'.  Declaration dropped.
browser/devtools/profiler/cleopatra/css/ui.css, line: 110 column: 13 source: "  user-select: none;"


user-select is currently only available vendor-prefixed. I guess I could understand wanting to keep this as it's (presumably?) just mirroring the github'd version of cleopatra (although it doesn't seem to have been updated since then?)

The linear-gradient thing is just wrong, AFAICT. Does it want to say "to left" instead?

Anton, you seem to have landed this originally in bug 795268. If updating this / fixing this is too much work, I can totally live with WONTFIX here, but I'm just filing all of the issues I find and leave it up to the relevant folks to decide what to do. :-)

Comment 1

[Panos Astithas (he/him) [:past] (please ni?)]

Victor is working on a profiler frontend rewrite that will no longer use cleopatra.

Comment 2

[Anton Kovalyov (:anton)]

This should be WONTFIX because we're ditching Cleopatra.

Comment 3

[:Gijs (he/him)]

Please remember to update the whitelist in the test file ( https://hg.mozilla.org/integration/fx-team/file/a38146bf6d18/browser/base/content/test/general/browser_parsable_css.js ) when you do remove cleopatra.

Thanks!