1004714 - Value selector uses mouse events when it should be using touch events

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Input Mgmt, defect)

Description

[Malini Das [:mdas] - Away, not checking bugmail]

value_selector.js expects mousedown events for drag gestures, but we do not dispatch mouse events for anything other than a tap. The de-facto standard we're using is 'mouse events for click, touch events for everything else', and so this breaks compatibility with our gesture automation and blocks Bug 946130.

As an example: https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/value_selector/value_selector.js#L72, this is the code handles the AM/PM selection animation, which *only* happens if you drag your fingers on it, ie: it is a gesture other than tap, and so it should use touch events. 

There are other mouse events used for picker objects in this file, so they may have the same issue.

Comment 1

[Jason Smith [:jsmith]]

Tim - This is blocking a bunch of on device automation in the system app (see bug 946130). Can you have someone look into this?

Comment 2

[Tim Guan-tin Chien [:timdream] (please needinfo)]

I don't expect we will be able to pick this up for 2.0 s1/s2, but I can set myself as assignee first until we have time to look at it.

Comment 3

[Mozilla Shepherd (This account is used for automation and doesn't receive bugmail)]

Attachment: mozilla-b2g:master PR#18977

Comment 4

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8417899 [details] [review]
mozilla-b2g:master PR#18977

The original line reported was unrelated to this issue; we listen mousedown event for canceling the focus from being taken away from the controls in app.

The actual mouse events to change is located in value_picker.js

Malini, would you try this patch and see if this do what you want?

Comment 5

[Malini Das [:mdas] - Away, not checking bugmail]

(In reply to Tim Guan-tin Chien [:timdream] (MoCo-TPE) (please ni?) from comment #4)
> Comment on attachment 8417899 [details] [review]
> mozilla-b2g:master PR#18977
> 
> The original line reported was unrelated to this issue; we listen mousedown
> event for canceling the focus from being taken away from the controls in app.
> 
> The actual mouse events to change is located in value_picker.js
Ah okay, thanks for the clarification
> 
> Malini, would you try this patch and see if this do what you want?

Yes, I've just tested it and it works perfectly, thank you!

Comment 6

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8417899 [details] [review]
mozilla-b2g:master PR#18977

f+ based on the above comment.

Comment 7

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 8417899 [details] [review]
mozilla-b2g:master PR#18977

Looks good to me.
Thanks.

Comment 8

[Tim Guan-tin Chien [:timdream] (please needinfo)]

master: https://github.com/mozilla-b2g/gaia/commit/49b6db5b06ba7ba39a9bc6d05248f9981edbb129