1004989 - [Homescreen] The downloading animation is not properly around the downloading icon

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[Julien Wajsberg [:julienw] (PTO -> Aug 14)]

Attachment: 2014-05-02-12-04-30.png

STR:
* launch Markerplace
* start the installation for "SOW"
* press home to see the "downloading" icon

=> See attachment

Image v1.4 for Peak from 2014-04-29:
Gecko: 44787e8
Gaia:  01b7794

Comment 1

[Jason Smith [:jsmith]]

Known bug & definitely not a blocker - VD glitch regression.

Comment 2

[Julien Wajsberg [:julienw] (PTO -> Aug 14)]

Just tried in master, it looks right.

So if this is not a blocker, let's close this.

Comment 3

[Julien Wajsberg [:julienw] (PTO -> Aug 14)]

I saw on Rik's phone that it's not fixed.

Comment 4

[Anthony Ricaud (:rik)]

My Peak is on 2.0,
Build identifier: 20140510071315
Git commit: 014d16ea

Comment 5

[Julien Wajsberg [:julienw] (PTO -> Aug 14)]

I believe this is an issue of HD vs non-HD.

Can we try on Open C on master?

Comment 6

[Ross Kuhlman ([e-mail])]

Attachment: IconAlignedOnOpenC.png

Installing icon is properly aligned on Open C Master build. Unable to reproduce issue.

Master M-C Environmental Variables:
Device: Open C Master M-C MOZ
BuildID: 20140513040202
Gaia: de1c755411949b50ae395b42e124af215ed9b702
Gecko: 7f5a8526b55a
Version: 32.0a1
Firmware Version: P821A10v1.0.0B06_LOG_DL

Comment 7

[Julien Wajsberg [:julienw] (PTO -> Aug 14)]

Can you try again, installing several apps, so that we can have an icon that is not at this location?

see attachment 8408632 [details] and attachment 8416417 [details], both icons are in the 3rd column.

Comment 8

[Cristian Rodriguez (:crdlc)]

Attachment: Patch v1

Please, can you test it in your Peak? Thanks a lot

Comment 9

[Anthony Ricaud (:rik)]

Attachment: with-patch.png

This screenshot was taken by applying your patch via the App Manager (so I'm not 100% sure all styles were properly applied).

Comment 10

[Julien Wajsberg [:julienw] (PTO -> Aug 14)]

Attachment: screenshot with the patch

Comment 11

[Julien Wajsberg [:julienw] (PTO -> Aug 14)]

Comment on attachment 8422286 [details]
Patch v1

My screenshot comes from v1.4, Rik's screenshot from master.

You can see that the ring is a little too small, and maybe 1 pixel too much to the left, but otherwise it's way better.

Comment 13

[Cristian Rodriguez (:crdlc)]

Comment on attachment 8422286 [details]
Patch v1

Following Julien's suggestion the circle looks perfect now. Thanks for the review Vivien and thanks for you help Julien!.

http://i.imgur.com/oSI6nyc.png

Comment 14

[Cristian Rodriguez (:crdlc)]

Is the 1.4 affected as well, right?

Comment 15

[Cristian Rodriguez (:crdlc)]

Thanks Anthony for your help!

(In reply to Anthony Ricaud (:rik) from comment #9)
> Created attachment 8422527 [details]
> with-patch.png
> 
> This screenshot was taken by applying your patch via the App Manager (so I'm
> not 100% sure all styles were properly applied).

Comment 16

[Julien Wajsberg [:julienw] (PTO -> Aug 14)]

(In reply to Cristian Rodriguez (:crdlc) from comment #14)
> Is the 1.4 affected as well, right?

yes definitely !

Comment 17

[Cristian Rodriguez (:crdlc)]

Merged in master:

https://github.com/mozilla-b2g/gaia/commit/6620361ef4b555a5d65aeffb79de96ca2ab518cc

Comment 18

[Anthony Ricaud (:rik)]

Thanks for this very quick fix!

Comment 19

[Julien Wajsberg [:julienw] (PTO -> Aug 14)]

Cristian, should we ask an approval here to land on v1.4, then?

Comment 20

[Cristian Rodriguez (:crdlc)]

Comment on attachment 8422286 [details]
Patch v1

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
[User impact] if declined: misaligned the downloading icon
[Testing completed]: user tests (developers)
[Risk to taking this patch] (and alternatives if risky): close to null
[String changes made]: no changes

Comment 21

[Preeti Raghunath(:Preeti)]

Comment on attachment 8422286 [details]
Patch v1

Taking for 1.4

Comment 22

[Ryan VanderMeulen [:RyanVM]]

v1.4: https://github.com/mozilla-b2g/gaia/commit/3144dde2846cd5b1b8bba98ae9162f98eee29cbc