1005368 - [Tarako][camera][gallery] Use new downsample.js utility to get scaling correct in cropResizeRotate()

Status: RESOLVED DUPLICATE of bug 1006882

(Firefox OS Graveyard :: Gaia::Gallery, defect)

Description

[David Flanagan [:djf]]

This is a followup to bug 989290, which modified the Camera and Gallery apps to use the #-moz-samplesize media fragment to downsample images while decoding them.

After landing that patch I discovered that I had misunderstood something important about the way that #-moz-samplesize works. (See bug 1004908).

As part of bug 1001724, I wrote a downsample.js utility for properly using #-moz-samplesize.

This bug is to convert the uses of #-moz-samplesize from bug 989290 to use the new utility.

I'm not certain whether there are any user-visible consequences of the bug, so we may not need to block on this (unless bug 1004908 gets addressed in 1.3T). Nevertheless, I'd sleep better if I could get this fix landed before we ship the Tarako.

Comment 1

[David Flanagan [:djf]]

Taking this bug and nominating for 1.3T.

Needinfo for Russ since he is porting bug 989290 to master and we should get this fix in to his patch before landing on master.

Comment 2

[Joe Cheng [:jcheng] (please needinfo)]

triage: not blocking
let's come back to this once we have a patch ready to land, then we can see if it is safe enough for 1.3T uplift. thanks

Comment 3

[Russ Nicoletti [:russn]]

I will be working on getting the bug 1001724 changes into master today.

Comment 4

[Russ Nicoletti [:russn]]

(In reply to Russ Nicoletti [:russn] from comment #3)
> I will be working on getting the bug 1001724 changes into master today.

More specifically, I will be working on merging the bug 1001724 changes into my local branch. All the 1.3t changes related to bug 949748 will be merged to master in one patch --> bug 1006039.

Comment 5

[Russ Nicoletti [:russn]]

Correction to comment #4: there will be two patches for getting 949748 into master: one for gallery changes (straightforward merging from 1.3t to master), one for camera changes (not straightforward merging since master camera code is very different from 1.3t code) -- this is similar to the approach for getting bug 989290 into master (see https://bugzilla.mozilla.org/show_bug.cgi?id=989290#c77)

I am working on getting bug 1001724 changes related to gallery into master -- changes related to camera will be taken care of by camera folks.

Comment 6

[David Flanagan [:djf]]

I'd forgotten that I filed this bug. The fix for this one is rolled in with bug 1006882. So if that patch lands, we can close this one.

Comment 7

[David Flanagan [:djf]]

Bug 1006882 has landed and includes a fix for this, so resolving this as a dupe