1005370 - Test that the webapp runtime automatically applies a prepared update

Status: RESOLVED FIXED

(Firefox Graveyard :: Webapp Runtime, defect)

Description

[Marco Castelluccio [:marco]]

This test would exercise the code that applies updates in the webapp runtime.

Comment 1

[Marco Castelluccio [:marco]]

Attachment: Patch

Comment 2

[Marco Castelluccio [:marco]]

This will help avoiding regressions in bug 910473.

Comment 3

[Marco Castelluccio [:marco]]

Astonishingly green on try: https://tbpl.mozilla.org/?tree=Try&rev=29f2717a41f2

Comment 4

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 8416778 [details] [diff] [review]
Patch

Review of attachment 8416778 [details] [diff] [review]:
-----------------------------------------------------------------

Looks great, and I love that you've also fixed all the intermittent oranges! ;-)

::: toolkit/webapps/tests/test_hosted_update_from_webapprt.xul
@@ +190,5 @@
> +  ok(true, "App launchable");
> +
> +  // Let the webapprt apply the update. The app.sjs?appreq page is accessed
> +  // only if the app is actually updated (because the old manifest contained
> +  // a different launch path).

Nit: instead of using the obscure abbreviation "webapprt", I would use the term "runtime", both in these comments and in the names of the files.

Comment 5

[Marco Castelluccio [:marco]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6807197e6add

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/6807197e6add