System dialogs have extra bottom space in Simulator

RESOLVED FIXED in 2.0 S1 (9may)

Status

Product:
Firefox OS Graveyard
Component:
Gaia::System
Type:
defect
Status:
RESOLVED FIXED
Opened:
5 years ago
Updated:
5 years ago

People

(Reporter: jryans, Assigned: jryans)

Tracking

Version:
unspecified
Target:
2.0 S1 (9may)
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

system-dialog-space.png
367.70 KB, image/png
Details
Github PR
46 bytes, text/x-github-pull-request
alive
: review+
Details | Review 
The Simulator disables the software home button, but the current system dialog CSS does not catch this case, so there's an extra space at the bottom.
Posted file Github PR —
Attachment #8416842 - Flags: review?(alive)
Comment on attachment 8416842 [details] [review]
Github PR

See github, thanks!
Attachment #8416842 - Flags: review?(alive)
Comment on attachment 8416842 [details] [review]
Github PR

Updated PR after review comments.
Attachment #8416842 - Flags: review?(alive)
Comment on attachment 8416842 [details] [review]
Github PR

Thank you!
Attachment #8416842 - Flags: review?(alive) → review+
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.0 S1 (9may)
You need to log in before you can comment on or make changes to this bug.