1005549 - Bug ###### Comment 2 doesn't mungered well for Comment anchor (case sensitivity problem)

Status: RESOLVED FIXED

(Other Applications :: ChatZilla, defect)

Description

[Robert Utasi [:hunboy]]

Bug 12345 Comment 2 mungered to
  http://bugzilla.mozilla.org/show_bug.cgi?id=12345

instead of
  http://bugzilla.mozilla.org/show_bug.cgi?id=12345#c2

case sensitivity problem

Comment 1

[Robert Utasi [:hunboy]]

Attachment: patch v1

using match instead og indexOf for handling the case sensitivity problem.

Comment 2

[James Ross]

Comment on attachment 8416962 [details] [diff] [review]
patch v1

Review of attachment 8416962 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good (and hilariously simple). r=silver with or without the nit fixed.

::: xul/content/mungers.js
@@ +326,2 @@
>          {
>              var commentNum = matchText.match(/comment\s+#?(\d+)/i)[1];

Nit: We could rearrange this code so it does this, more complete, .match() before the if and just check the result of that.

Comment 3

[Robert Utasi [:hunboy]]

Attachment: patch v1.1

nit fixed patch

Comment 4

[James Ross]

http://hg.mozilla.org/chatzilla/rev/1cc8ce7571fa