1005637 - Configure OMX H264 encoder correctly to start

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, defect, P2)

Description

[Randell Jesup [:jesup] (needinfo me)]

The H.264 HW OMX encoder is picking up a bunch of default settings made in OMXCodecSupport.cpp which appear to be intended for a different usecase (2Mbps, etc).

I've implemented an alternative API to configure() that allows passing an AMessage in with the settings we want.

There's still an open question on exactly what those settings are.

Comment 1

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Add support for controlling the OMX encoder config settings

Comment 2

[:shell escalante]

This falls after the SDP and packetization work Randell's doing. working on unblocking through partnering.

Comment 3

[Randell Jesup [:jesup] (needinfo me)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/120d830b89e2

Comment 4

[Randell Jesup [:jesup] (needinfo me)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/76a7d720a9a3
Accidentally included a change in SetBitrate() ro the parameter name (to the KK version) when I qref'd to add r=roc; this backs that out.

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/120d830b89e2
https://hg.mozilla.org/mozilla-central/rev/76a7d720a9a3