Closed Bug 1005637 Opened 6 years ago Closed 6 years ago

Configure OMX H264 encoder correctly to start

Categories

(Core :: WebRTC: Audio/Video, defect, P2)

ARM
Gonk (Firefox OS)
defect

Tracking

()

RESOLVED FIXED
mozilla32
feature-b2g 2.0

People

(Reporter: jesup, Assigned: jesup)

References

Details

(Whiteboard: [s=fx32, p=.25])

Attachments

(1 file)

The H.264 HW OMX encoder is picking up a bunch of default settings made in OMXCodecSupport.cpp which appear to be intended for a different usecase (2Mbps, etc).

I've implemented an alternative API to configure() that allows passing an AMessage in with the settings we want.

There's still an open question on exactly what those settings are.
Blocks: 989945
This falls after the SDP and packetization work Randell's doing. working on unblocking through partnering.
Priority: -- → P2
Whiteboard: [s=fx32, p=.25]
Target Milestone: --- → mozilla32
Attachment #8417032 - Flags: review?(roc)
https://hg.mozilla.org/integration/mozilla-inbound/rev/76a7d720a9a3
Accidentally included a change in SetBitrate() ro the parameter name (to the KK version) when I qref'd to add r=roc; this backs that out.
feature-b2g: --- → 2.0
Blocks: 1016359
You need to log in before you can comment on or make changes to this bug.