1005792 - [Tarako][Gallery] Can load the pictures which are larger than 2MP, and email got killed when attach the picture to email

Status: RESOLVED DUPLICATE of bug 1006882

(Firefox OS Graveyard :: Gaia::Gallery, defect)

Description

[Bingqing Li]

Attachment: logcat

On build 20140504014000, it could load the pictures which are larger than 2MP.

When attach those pictures to an email, email got killed due to LMK.


Build Info:
----------------------------------------------------
Gaia      1177a857a3caeb8fd1feae94c83298a9144c2ff5
Gecko     https://hg.mozilla.org/releases/mozilla-b2g28_v1_3t/rev/d28bb1e73b91
BuildID   20140504014000
Version   28.1
ro.build.version.incremental=eng.cltbld.20140504.045422
ro.build.date=Sun May  4 04:54:31 EDT 2014

Comment 1

[John Hu [:johnhu][:johu][:醬糊小弟]]

James,

We had confirmed this issue at bug 998228. Please confirm this again at your site.

Comment 2

[James Zhang (Spreadtrum)]

Please see camera.json on my side.
Need I config any other value?


{
   "maxImagePixelSize": 2097152,
   "maxSnapshotPixelSize": 1920000,
   "maxGifImageFileSize": 1048576,
   "maxPickPixelSize": 480000,
   "maxEditPixelSize": 480000
}

Comment 3

[James Zhang (Spreadtrum)]

I don't find email.json in the url. So I think my camera.json is OK for camera and gallery.
https://developer.mozilla.org/en-US/Firefox_OS/Developing_Firefox_OS/Market_customizations_guide

Comment 4

[John Hu [:johnhu][:johu][:醬糊小弟]]

Thanks James,

The camera.json is correct. So, how can we have a image more than 2MP in that case? May you provide us the STR about this bug?

We had already confirmed the 2MP limitation working at bug 998228.

Comment 5

[Bingqing Li]

Attachment: Picture for test

Here is the picture used for testing.

(In reply to John Hu [:johnhu][:johu][:醬糊小弟] from comment #4)
> Thanks James,
> 
> The camera.json is correct. So, how can we have a image more than 2MP in
> that case? May you provide us the STR about this bug?
> 
> We had already confirmed the 2MP limitation working at bug 998228.

John, actually this bug was found by me when I tried to reproduce a bug filed by spreadtrum. The spreadtrum bug complains that email gets killed when add attachment to an email.

I can reproduce the spreadtrum bug on build 20140504014000, but the weird thing is that the attachment I used is larger than 2MP. (Pls see the attachment.)


STR:
-------------------------------------
1. Launch Email
2. Create a new mail
3. Attach the picture to the email

p.s. The picture is copied from PC to the sdcard.
     It can be attached to a MMS successfully.

Comment 6

[John Hu [:johnhu][:johu][:醬糊小弟]]

I got what's going on. Thanks for the attachment.

The code had been changed by Bug 1001724. We block all images with more than 2MP. But the patch of Bug 1001724 changes that to non-JPG image with more than 2MP[1]. That introduces this bug. I can fix it asap. But we still need to ask the patch owner about why.

David, would you mind to tell us why we changed the limitation from all images to non-JPG images?

[1] https://github.com/mozilla-b2g/gaia/blame/c067cc717c4a3bb8b412f28f37d224eb84b639df/apps/gallery/js/MetadataParser.js#L198

Comment 7

[John Hu [:johnhu][:johu][:醬糊小弟]]

Attachment: patch of this bug

The simple patch to revert to limit all image with more than 2MP.

Comment 8

[Joe Cheng [:jcheng] (please needinfo)]

triage: 1.3T+ to take this

Comment 9

[David Flanagan [:djf]]

Thank you John for your work on this.

I discovered this bug yesterday. I caused this regression with a recent landing. I already have a fix that will allow large images to be picked. We don't have to put the limit back.

I'll attach a patch soon.

Comment 10

[David Flanagan [:djf]]

I've attached a patch to bug 1006882 that includes a fix for this bug.

Comment 11

[Justin D'Arcangelo [:justindarc]]

Closing this as a duplicate of 1006882. The patch in 1006882 is pending review and has been tested to verify that it does resolve this issue.