998228 - Ensure Tarako has 2mp image size limit set

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Vendcom, defect)

Description

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Tarako has too few memory to handle image bigger than 2 meta pixels. We need to ensure the build is being configured so.

Bug filed as a placeholder for dup.

Comment 2

[thomas tsai]

Vincent will update the customization patch.

Comment 3

[Vincent Liu[:vliu]]

I'd worked out a way to set camera.json in device folder. Currently tarako exposes GAIA_DISTRIBUTION_DIR in device folder so we can generate a camera.json in the path GAIA_DISTRIBUTION_DIR assigned and then applications-data.js parses it in build time to set parameters into config.js in Camera/Gallery app.

Currently there are two parameters, says maxImagePixelSize and maxSnapshotPixelSize. Both of them are set to 5 * 1024 *1024. For the issue we met, my idea is both of these two values set to 2 * 1024 *1024. @Tim, do you have any concern for this? Thanks.

Comment 4

[Vincent Liu[:vliu]]

From the following code in Camera app, I think it should be the same that we only set maxImagePixelSize or set both to 2MP. 

    var maxRes = Math.min(CONFIG_MAX_IMAGE_PIXEL_SIZE,
      CONFIG_MAX_SNAPSHOT_PIXEL_SIZE);

Comment 5

[Vincent Liu[:vliu]]

Attachment: camera.json

Hi James,

The attached camera.json is an example for this issue. Please put this file to in the device folder like settings.json did. If you have any problem, please let me know. Thanks.

Comment 6

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Yes, that's correct.

Comment 7

[James Zhang (Spreadtrum)]

(In reply to Vincent Liu[:vliu] from comment #5)
> Created attachment 8408869 [details]
> camera.json
> 
> Hi James,
> 
> The attached camera.json is an example for this issue. Please put this file
> to in the device folder like settings.json did. If you have any problem,
> please let me know. Thanks.

You mean put these param to setting.json in device/sprd ?

Comment 8

[James Zhang (Spreadtrum)]

Put camera.json into device/sprd or put its param into setting.json in device/sprd?

Comment 9

[thomas tsai]

camera.json into device/sprd.

Comment 10

[James Zhang (Spreadtrum)]

Fixed on my side, is it ok?

commit fb1e12b7b5b773f415d420d51e513844461f6224
Author: james.zhang <[e-mail]>
Date:   Sat Apr 19 14:13:46 2014 +0800

    Bug#269156 mozilla Bug 998228 - Ensure Tarako has 2mp image size limit set
    
    [bug number  ]
    [root cause  ]
    [changes     ]
    [side effects]
    [self test   ] yes
    [reviewers   ]
    
    Change-Id: I7367505b5dc63fb89a64668e6c0c97423332f7f9

Comment 11

[Vincent Liu[:vliu]]

(In reply to James Zhang from comment #8)
> Put camera.json into device/sprd or put its param into setting.json in
> device/sprd?

Put camera.json into device/sprd, the same path with settings.json.

Comment 12

[James Zhang (Spreadtrum)]

fixed on my side.

Comment 13

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

Verified the fix.  I was unable to get 2MP or larger sized images to show on Tarako.

1.3T Environmental Variables:
Device: Tarako 1.3T MOZ
BuildID: 20140430014008
Gaia: f9b62bd1135f4edf8317fff1c2947b9d99438d79
Gecko: ba50f734b815
Version: 28.1
Firmware Version: sp6821a-Gonk-4.0-4-29

Comment 14

[jingmei.zhang]

hi vliu:
  
   I have  a little confusion about the image size limit in 1.4.
   In 1.3,we have a different size limitation between 'gif' and other image formate ,the codes are as follows:

// If the image is lower resolution but with large file size, like
// animated GIF, we should not decode it.
> if ((file.type === 'image/gif' || file.name.endsWith('.gif')) &&
>  file.size > 0.1*CONFIG_MAX_IMAGE_PIXEL_SIZE) {
>   metadataError('Ignoring acceptable resolution but large gif file ' +
>               file.name);
>     return;
> } 

  but in 1.4,I don't see such a limitation in format 'gif',so should we add the similar codes in 1.4??
  Looking forward to your reply!
  Thank you very much!

Comment 15

[Vincent Liu[:vliu]]

I believe Diego Marcos can have a better answer for your question.

Comment 16

[Diego Marcos [:dmarcos]]

 jingmei, The snippet you referenced belongs to gallery. djf can provide a more accurate answer to explain why gif images are not treated as special case anymore in 1.4

Comment 17

[jingmei.zhang]

(In reply to Diego Marcos [:dmarcos] from comment #16)
>  jingmei, The snippet you referenced belongs to gallery. djf can provide a
> more accurate answer to explain why gif images are not treated as special
> case anymore in 1.4

thank you,Diego Marcos.

I have filed a new bug for this issue,and ni djf there.

Thank you again for your help!