1005886 - [NFC] encodeHandoverSelect() fixes and tests

Status: RESOLVED FIXED

(Firefox OS Graveyard :: NFC, defect)

Description

[Kamil Leszczuk [:kamituel]]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_9_2) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/34.0.1847.131 Safari/537.36




Expected results:

As of current implementation, encodeHandoverSelect() accepts any CPS value and attempts to include it into handover select message. But according to [CH] spec (v. 1.3), it's only valid values are: 0, 1, 2, 3 ("inactive", "active", "activating" and "unknown" respectively). 

Also, encodeHandoverSelect() could be used in NfcHandoverManager/NFC Pairing UI unit tests, but it'd need to accept an optional, third parameter "btName" (user-friendly name of the device) and encode it appropriately. It's described in "Bluetooth Secure Simple Pairing Using NFC" spec (example message in table 5).

This would be the first unit test for any methods in nfc_manager_utils.js. More should follow, and I'd be happy to work on those as well.

Comment 1

[Kamil Leszczuk [:kamituel]]

Anyone, please assign this to me.

Comment 2

[Kamil Leszczuk [:kamituel]]

Attachment: Fixes and unit tests for encodeNdefMessage(). Support for bluetooth device name encoding.

Comment 3

[Kamil Leszczuk [:kamituel]]

I meant "fixes and unit tests for encodeHandoverSelect()" of course.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Master: https://github.com/mozilla-b2g/gaia/commit/87b4051401115f49601166025aad513d06257d0a

Comment 5

[Kamil Leszczuk [:kamituel]]

Thank you @Alive for prompt review and @Ryan for even prompter merge :)