Closed
Bug 1005898
Opened 11 years ago
Closed 11 years ago
Make WebIDL properties on all globals be own properties
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla32
People
(Reporter: peterv, Assigned: peterv)
References
Details
Attachments
(2 files, 1 obsolete file)
6.36 KB,
patch
|
Details | Diff | Splinter Review | |
14.94 KB,
patch
|
peterv
:
review+
|
Details | Diff | Splinter Review |
I've centralized the decision about own vs non-own properties in one place, so it is easier to switch behaviour on branches.
Attachment #8417386 -
Flags: review?(bzbarsky)
Assignee | ||
Comment 1•11 years ago
|
||
BTW, this leaves the initing of ids and pref caches in CreateInterfaceObjects. I think that's fine because we're calling CreateInterfaceObjects first anyway. Let me know if you disagree and want this moved to Wrap instead.
![]() |
||
Comment 2•11 years ago
|
||
Comment on attachment 8417386 [details] [diff] [review]
v1
The PostCreate change looks wrong to me, since it will also skip defining unforgeable attributes, no? And we want those on the object no matter what GlobalPropertiesAreOwn() returns.
r=me with that fixed, though I'd like to see the updated patch.
Attachment #8417386 -
Flags: review?(bzbarsky) → review+
Assignee | ||
Comment 3•11 years ago
|
||
Assignee | ||
Comment 4•11 years ago
|
||
Attachment #8417386 -
Attachment is obsolete: true
Attachment #8421029 -
Flags: review+
![]() |
||
Comment 5•11 years ago
|
||
Looks great, thank you!
Assignee | ||
Comment 6•11 years ago
|
||
Comment 7•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•