1005898 - Make WebIDL properties on all globals be own properties

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Peter Van der Beken [:peterv]]

Attachment: v1

I've centralized the decision about own vs non-own properties in one place, so it is easier to switch behaviour on branches.

Comment 1

[Peter Van der Beken [:peterv]]

BTW, this leaves the initing of ids and pref caches in CreateInterfaceObjects. I think that's fine because we're calling CreateInterfaceObjects first anyway. Let me know if you disagree and want this moved to Wrap instead.

Comment 2

[Boris Zbarsky [:bzbarsky, bz on IRC]]

Comment on attachment 8417386 [details] [diff] [review]
v1

The PostCreate change looks wrong to me, since it will also skip defining unforgeable attributes, no?  And we want those on the object no matter what GlobalPropertiesAreOwn() returns.

r=me with that fixed, though I'd like to see the updated patch.

Comment 3

[Peter Van der Beken [:peterv]]

Attachment: Interdiff v1 to 1.1

Comment 4

[Peter Van der Beken [:peterv]]

Attachment: v1.1

Comment 5

[Boris Zbarsky [:bzbarsky, bz on IRC]]

Looks great, thank you!

Comment 6

[Peter Van der Beken [:peterv]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/056788c50647

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/056788c50647