Closed Bug 1005898 Opened 5 years ago Closed 5 years ago

Make WebIDL properties on all globals be own properties

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla32

People

(Reporter: peterv, Assigned: peterv)

References

Details

Attachments

(2 files, 1 obsolete file)

Attached patch v1 (obsolete) — Splinter Review
I've centralized the decision about own vs non-own properties in one place, so it is easier to switch behaviour on branches.
Attachment #8417386 - Flags: review?(bzbarsky)
BTW, this leaves the initing of ids and pref caches in CreateInterfaceObjects. I think that's fine because we're calling CreateInterfaceObjects first anyway. Let me know if you disagree and want this moved to Wrap instead.
Comment on attachment 8417386 [details] [diff] [review]
v1

The PostCreate change looks wrong to me, since it will also skip defining unforgeable attributes, no?  And we want those on the object no matter what GlobalPropertiesAreOwn() returns.

r=me with that fixed, though I'd like to see the updated patch.
Attachment #8417386 - Flags: review?(bzbarsky) → review+
Attached patch v1.1Splinter Review
Attachment #8417386 - Attachment is obsolete: true
Attachment #8421029 - Flags: review+
Looks great, thank you!
https://hg.mozilla.org/mozilla-central/rev/056788c50647
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
Depends on: 1225782
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.