Closed Bug 1005898 Opened 5 years ago Closed 5 years ago
IDL properties on all globals be own properties
I've centralized the decision about own vs non-own properties in one place, so it is easier to switch behaviour on branches.
Attachment #8417386 - Flags: review?(bzbarsky)
BTW, this leaves the initing of ids and pref caches in CreateInterfaceObjects. I think that's fine because we're calling CreateInterfaceObjects first anyway. Let me know if you disagree and want this moved to Wrap instead.
Comment on attachment 8417386 [details] [diff] [review] v1 The PostCreate change looks wrong to me, since it will also skip defining unforgeable attributes, no? And we want those on the object no matter what GlobalPropertiesAreOwn() returns. r=me with that fixed, though I'd like to see the updated patch.
Attachment #8417386 - Flags: review?(bzbarsky) → review+
Looks great, thank you!
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
You need to log in before you can comment on or make changes to this bug.