1006318 - [B2G][MMS] Some properties defined in MmsConnection.prototype shall be treated as instance variables instead of static variables.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: RIL, defect)

Description

[Bevis Tseng[:bevis][:btseng](Exited)]

Fire this bug to address the problem below:

When supporting DSDS for MmsService, we modify the design of MmsConnection to
be a user-defined prototype to allow being initiated into multiple instances and
each represent the mms connection of specified serviceId.

However, the following properties in MmsConnection still behaves as single instance even when multiple MmsConnections are created:
1. pendingCallbacks
2. connectTimer
3. disconnectTimer
This will cause the MmsConnection behaves abnormally especially when DSDA device is introduced.

Comment 1

[Bevis Tseng[:bevis][:btseng](Exited)]

Attachment: Patch v1: Assign values in constructor to ensure these properties are created per instance. r=vyang.

1. Assign values of these properties in Constructor to ensure these properties are created per instance.
2. Add an debug log for better debugging during field trial when sending MMS failed.

Comment 2

[Bevis Tseng[:bevis][:btseng](Exited)]

try server result is green:
https://tbpl.mozilla.org/?tree=Try&rev=f7ef2d8eb995

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/ad6dfb02aacc

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/ad6dfb02aacc