1006324 - [DSDS] After PUK is locked, SIM manager did not show "No SIM card" on the locked SIM and all outgoing settings are not changed to another SIM based on UX spec. Cloned from 962927

Status: RESOLVED WORKSFORME

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Eric Chang [:ericcc] [:echang]]

[DSDS] After PUK is locked, SIM manager did not show "No SIM card" on the locked SIM and all outgoing settings are not changed to another SIM based on UX spec. 

Cloned from 962927.

Based on 1.3 DSDS v0.8 UX spec, page 44, item 3, once entering 10 incorrect PUK code, SIM cards manager shows "No SIM card" of the locked SIM and all the settings(outgoing voice, data and message) will be set to another on service SIM.

But on Fugu, it still shows "No operator" on locked SIM(SIM 1 in attached screenshot) and all settings are not changed to SIM2.

Comment 1

[Eric Chang [:ericcc] [:echang]]

Attachment: v1.4 on Dolphin.JPG

It shows "SIM Pin locked", and prompts for PUK when entering dialer. 

### v1.4 on <Dolphin>
Your Target Build: B2G.v1.4.0.dolphin     
Gaia      fccb15d6940db51615545574877a62d69406b1c2
Gecko     3ed3bbf1941e608bc9630942c7063a8b818f36bc
BuildID   20140505085052                  
Version   30.0

Comment 2

[Eric Chang [:ericcc] [:echang]]

Attachment: Page 44 of [SPEC] DSDS v0.8 .png

v1.3 Spec

Comment 3

[Eric Chang [:ericcc] [:echang]]

https://bugzilla.mozilla.org/show_bug.cgi?id=962927

Comment 4

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Thanks Eric, I would take this bug !

Comment 5

[Jason Smith [:jsmith]]

Why is this a blocker? We've shipped with this problem already. We should really only block on bad new feature bugs or regressions primarily.

Comment 6

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Attachment: before.png

Comment 7

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Attachment: mimic_gecko_event.png

Comment 8

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Eric,

I double-checked my code and it should work as expected like what UX spec mentioned. To prove this, I modified my desktop client to make some fake events from Gecko and the flow is right (You can compare before.png with mimic_gecko_event.png).

And also, I noticed that your screenshot of dolphin is wrong because it looks like the first card got simlocked instead of permanentBlocked. I am suspecting the upcoming event from Gecko (modem) is wrong.

Any idea ?

Comment 9

[Eric Chang [:ericcc] [:echang]]

Attachment: SIMmanager.log

This on does not looks like it is locked by PUK, isn't it??
05-08 13:16:17.695   109   109 I Gecko   : -*- RadioInterface[0]: Received message from worker: {"lockType":"pin","requestId":"id{7c9aac77-f6f2-48bd-9236-420eb9827df6}","rilMessageClientId":0,"rilMessageToken":43,"rilMessageType":"iccGetCardLockState","facility":"SC","password":"","serviceClass":7,"rilRequestType":42,"rilRequestError":14,"success":false,"errorMsg":"GenericFailure"}
05-08 13:16:18.246   109   109 I Gecko   : -*- RadioInterface[0]: Received message from worker: {"lockType":"pin","requestId":"id{6de83d69-a640-4be2-b527-253f3d9635ed}","rilMessageClientId":0,"rilMessageToken":44,"rilMessageType":"iccGetCardLockState","facility":"SC","password":"","serviceClass":7,"rilRequestType":42,"rilRequestError":14,"success":false,"errorMsg":"GenericFailure"}

Comment 10

[Eric Chang [:ericcc] [:echang]]

Attachment: Dialer.log

But if I opened from Dialer, it shows different message, I am not sure I can use Dolphin to verify this bug.

05-08 13:16:17.695   109   109 I Gecko   : -*- RadioInterface[0]: Received message from worker: {"lockType":"pin","requestId":"id{7c9aac77-f6f2-48bd-9236-420eb9827df6}","rilMessageClientId":0,"rilMessageToken":43,"rilMessageType":"iccGetCardLockState","facility":"SC","password":"","serviceClass":7,"rilRequestType":42,"rilRequestError":14,"success":false,"errorMsg":"GenericFailure"}
05-08 13:16:18.246   109   109 I Gecko   : -*- RadioInterface[0]: Received message from worker: {"lockType":"pin","requestId":"id{6de83d69-a640-4be2-b527-253f3d9635ed}","rilMessageClientId":0,"rilMessageToken":44,"rilMessageType":"iccGetCardLockState","facility":"SC","password":"","serviceClass":7,"rilRequestType":42,"rilRequestError":14,"success":false,"errorMsg":"GenericFailure"}
05-08 13:17:39.265   109   109 I Gecko   : -*- RadioInterface[0]: Received message from worker: {"lockType":"puk","requestId":"id{b67b90ab-4c23-4b75-b098-aa340e38d1e4}","rilMessageClientId":0,"rilMessageToken":45,"rilMessageType":"iccGetCardLockRetryCount","selCode":"SIM PUK","rilRequestType":150,"rilRequestError":0,"success":true,"retryCount":10}
05-08 13:17:43.118   109   109 I Gecko   : -*- RadioInterface[0]: Received 

v2.0 on dolphin
Gaia      749b6775960ac5404e95d802db776ff7d064e02c
Gecko     5808b61ad47787bdf7a0b0c70e995387357e384a
BuildID   20140507053053
Version   32.0a1

Comment 11

[Eric Chang [:ericcc] [:echang]]

Hi, Hsinyi, Could you help to comment on this, thank you.

Comment 12

[Hsin-Yi Tsai (she/her)[:hsinyi]]

Just discussed with Eric, the log in comment 9 is gotten while he put a puk-locked sim into the device and then opened Settings App. Log in comment 10 is gotten while he put a puk-locked sim and then opened Dialer app.

From comment 10, there's one more request "iccGetCardLockRetryCount" which is missing in comment 9.

EJ, do you have any idea about the differences b/w Dialer and Settings? Why is there no "GetCardLockRetryCount" from Settings app? Thanks!

Comment 13

[Eric Chang [:ericcc] [:echang]]

Attachment: Security.log

Tap Settings -> Sim Manager -> Sim security -> toggle SIM 1 Pin -> prompt for PUK.
We have the log with PUK here.

05-08 14:57:22.882   109   109 I Gecko   : -*- RadioInterface[0]: Received message from worker: {"lockType":"pin","requestId":"id{4a649387-2eab-4496-be16-626ef39baee1}","rilMessageClientId":0,"rilMessageToken":57,"rilMessageType":"iccGetCardLockState","facility":"SC","password":"","serviceClass":7,"rilRequestType":42,"rilRequestError":14,"success":false,"errorMsg":"GenericFailure"}
05-08 14:57:23.323   109   109 I Gecko   : -*- RadioInterface[0]: Received message from worker: {"voice":{"signalStrength":-83,"relSignalStrength":100},"data":{"signalStrength":-83,"relSignalStrength":100},"rilMessageType":"signalstrengthchange","rilMessageClientId":0}
05-08 14:57:23.413   109   109 I Gecko   : -*- RadioInterface[0]: Received message from worker: {"lockType":"pin","requestId":"id{a958ebaa-4da8-494b-b9e3-a64a45434688}","rilMessageClientId":0,"rilMessageToken":58,"rilMessageType":"iccGetCardLockState","facility":"SC","password":"","serviceClass":7,"rilRequestType":42,"rilRequestError":14,"success":false,"errorMsg":"GenericFailure"}
05-08 14:57:24.073   109   109 I Gecko   : -*- RadioInterface[0]: Received message from worker: {"lockType":"pin","requestId":"id{a462eda3-b2db-4688-8f24-35603400bbbe}","rilMessageClientId":0,"rilMessageToken":59,"rilMessageType":"iccGetCardLockState","facility":"SC","password":"","serviceClass":7,"rilRequestType":42,"rilRequestError":14,"success":false,"errorMsg":"GenericFailure"}
05-08 14:57:25.305   109   109 I Gecko   : -*- RadioInterface[0]: Received message from worker: {"lockType":"puk","requestId":"id{90ceb0f3-d3e2-4a0c-b64f-701ec01c1260}","rilMessageClientId":0,"rilMessageToken":61,"rilMessageType":"iccGetCardLockRetryCount","selCode":"SIM PUK","rilRequestType":150,"rilRequestError":0,"success":true,"retryCount":10}

Comment 14

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

(In reply to Hsin-Yi Tsai  [:hsinyi] from comment #12)
> EJ, do you have any idea about the differences b/w Dialer and Settings? Why
> is there no "GetCardLockRetryCount" from Settings app? Thanks!

From settings, we send this request to Gecko only when simPinDialog is shown. There are two ways to get here by clicking on the toggle and clicking on `change sim pin` button. 

SO, the reason why the request was missing on comment #10 is because Eric didn't trigger them by ways I mentioned above.

You can check latest comment (comment #13) which Eric did the right way to send the request to Gecko ! (Tap Settings -> Sim Manager -> Sim security -> toggle SIM 1 Pin -> prompt for PUK.)

But I am not sure why we have to make sure this event is sent to Gecko or not ? Is it related to the bug syndrome ? (!?)

To be clear, this bug focuses on fixing the situation that when receiving `cardstatechange` from Gecko and noticed targeted simcard.cardStatus is permanentBlocked, Gaia have to gray out targeted sim UI and change all settings to another card.

Hope this helps, thanks ;)

Comment 15

[Hsin-Yi Tsai (she/her)[:hsinyi]]

Thanks EJ. :)

So, I checked the log again, and then realized that the information coming from modem isn't as expected.
================
05-08 13:14:17.808   109   461 I Gecko   : RIL Worker: [1] iccStatus: {"cardState":1,"universalPINState":0,"gsmUmtsSubscriptionAppIndex":0,"cdmaSubscriptionAppIndex":8,"imsSubscriptionAppIndex":8,"apps":[{"app_type":2,"app_state":5,"perso_substate":2,"aid":null,"app_label":null,"pin1_replaced":0,"pin1":0,"pin2":0}]}
===============

According to [1], when pin1_replaced is 0, pin1 should be "CARD_PINSTATE_ENABLED_PERM_BLOCKED (5)" if puk retrycount is 10, permanetBlocked. However, now the pin1 reported is 0. Should ask our partner for confirmation.

[1] dxr.mozilla.org/mozilla-central/source/dom/system/gonk/ril_worker.js?from=ril_worker.js&case=true#3285

Comment 16

[Hsin-Yi Tsai (she/her)[:hsinyi]]

NI Sam for comment 15, thanks!

Comment 17

[sam.hua]

Hi Hsin,

We will convert to modem block=6 when puk is locked after puk retrycount is 0,not 10.
        /* SIM_BLOCK = 6 */
        { RIL_APPTYPE_SIM, RIL_APPSTATE_BLOCKED, RIL_PERSOSUBSTATE_UNKNOWN,
            NULL, NULL, 0, RIL_PINSTATE_UNKNOWN, RIL_PINSTATE_UNKNOWN },

but if puk retrycount is 10, it should be in RIL_APPSTATE_UNKNOWN(0). now sim isn't blocked.

Comment 18

[Hsin-Yi Tsai (she/her)[:hsinyi]]

(In reply to sam.hua from comment #17)
> Hi Hsin,
> 
> We will convert to modem block=6 when puk is locked after puk retrycount is
> 0,not 10.
>         /* SIM_BLOCK = 6 */
>         { RIL_APPTYPE_SIM, RIL_APPSTATE_BLOCKED, RIL_PERSOSUBSTATE_UNKNOWN,
>             NULL, NULL, 0, RIL_PINSTATE_UNKNOWN, RIL_PINSTATE_UNKNOWN },
> 
> but if puk retrycount is 10, it should be in RIL_APPSTATE_UNKNOWN(0). now
> sim isn't blocked.

Oh... yes, you are right. Thanks, Sam. :)

Hi Eric,
Per Sam's explanation, now retrycount is 10, so seems nothing wrong.
Please try to type wrong PUK 10 times, and see if this issue is still valid.

Comment 19

[Eric Chang [:ericcc] [:echang]]

Attachment: NoSimCard.png

Got that, Thanks a lot, everyone.
It is fixed, see pix.

Comment 20

[Eric Chang [:ericcc] [:echang]]

Tt is already in 1.4, v2.0 also has this fixs, thanks.
Gaia      749b6775960ac5404e95d802db776ff7d064e02c
Gecko     5808b61ad47787bdf7a0b0c70e995387357e384a
BuildID   20140507053053
Version   32.0a1