Closed Bug 1006326 Opened 8 years ago Closed 7 years ago
Enable 'box-decoration-break' by default
No description provided.
What blocks enabling it on all builds (Nightly + Release)?
I probably think it requires a tiny bit more testing.
The remaining piece is to implement layout of box-decoration-break:clone for block margins: bug 1025669. I don't know if that needs to block enabling it though. In particular, b-d-b should be fully working for inlines as a replacement for -moz-background-inline-policy.
Is there a particular reason this should only be enabled for Nightly, or can we enable it and let it ride the trains?
The implementation should be complete now, except for clip-path/clip/mask in bug 988659. Do we want to block on that bug?
I think we do *not* want to block, though I don't have a good sense of how hard it is. (My guess is that it's hard-ish.)
Looks green so far... https://tbpl.mozilla.org/?tree=Try&rev=ee02ec9cf863 https://tbpl.mozilla.org/?tree=Try&rev=a7c6113b1fb4
Assignee: nobody → mats
Attachment #8451167 - Flags: review?(roc)
OK, so for FF32 I would recommend we uplift bug 1025669 (block margins), bug 1031444 (bug fix) and bug 1031726 (clip:rect()) and then enable it by default there too. Does that seem reasonable?
Attachment #8451167 - Flags: review?(roc) → review+
BTW, should we post an "intent to ship" about this property?
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
(In reply to Mats Palmgren (:mats) from comment #10) > BTW, should we post an "intent to ship" about this property? Yes I believe we should do that with all new Web-exposed features.
OK, will do so as soon as dbaron responds to the n-i in comment 8. The patches for Aurora are green on Try, fwiw: https://tbpl.mozilla.org/?tree=Try&rev=98bad8e3d58f
(In reply to Mats Palmgren (:mats) from comment #8) > OK, so for FF32 I would recommend we uplift bug 1025669 (block margins), > bug 1031444 (bug fix) and bug 1031726 (clip:rect()) and then enable it > by default there too. > > Does that seem reasonable? It's a little bit of a stretch of the purpose of Aurora, but I think it seems reasonable given that it avoids having the feature disappear for one release and then come back with a new name in the following one (right?).
Right, the uplift is intended to avoid that. Great, so I'll request approval on the patches in the relevant bugs as usual then.
Comment on attachment 8451167 [details] [diff] [review] fix Approval Request Comment [Feature/regressing bug #]: We want to enable 'box-decoration-break' by default on Aurora to provide an upgrade path for a property that were removed (-moz-background-inline-policy). [User impact if declined]: Web pages that use the old property will have some element's background image displayed slightly wrong, and there will be one cycle without an upgrade path to fix that. [Describe test coverage new/current, TBPL]: It's enabled by default on m-c. Most of the 'box-decoration-break' patches are already on Aurora but the feature is currently disabled by default. [Risks and why]: minor risk [String/UUID change made/needed]: none
Attachment #8451167 - Flags: approval-mozilla-aurora?
Summary: Enable 'box-decoration-break' by default in Nightly → Enable 'box-decoration-break' by default
Comment on attachment 8451167 [details] [diff] [review] fix Aurora+
Attachment #8451167 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Release note should include that box-decoration-break replaces -moz-background-inline-policy, which has been removed from Firefox 32. Mats - Can you write a draft release note about this change? Is the following correct? If this is not a direct replacement it may be better to have a note about the removal and a note about the new property. "-moz-background-inline-policy CSS property replaced with box-decoration-break" As well, is the upgrade path documented somewhere that we can link to from the release notes?
I think the text on the MDN page might work as guidance for authors: https://developer.mozilla.org/en-US/docs/Web/CSS/-moz-background-inline-policy "This property has been standardized in css3-background with the name box-decoration-break, except that box-decoration-break applies to borders in addition to backgrounds. The continuous value is equivalent to slice, and the each-box value is equivalent to clone. An equivalent to the bounding-box value was not included in the standard, and the functionality is likely to be removed when the standard feature is implemented." The spec has changed since then, it's css-break, not css3-background. http://dev.w3.org/csswg/css-break/#break-decoration We should also update the current MDN page for b-d-b, which looks out of date: https://developer.mozilla.org/en-US/docs/Web/CSS/box-decoration-break (and link to it from the former page)
(btw, I'm updating those MDN pages a bit, while watching the tree...)
I have updated the MDN pages. I'd like to add a more prominent "obsolete" warning on the -moz-background-inline-policy page but I don't know how to do that. I tried to link the CSS spec "CSS Fragmentation Module Level 3" on the box-decoration-break page but MDN doesn't seem to recognize it as a valid spec name and I don't know how to make it one. (I've added a plain external link there for now.)
Mats, I've added enough "warnings" on -moz-b-i-p I think. I also fixed the link on box-decoration-box and made slight modification to match our look and feel. I updated the text on Fx 32 for devs too. I think we have an up-to-date doc for this property. Mats, thanks for the very valuable help! Nice examples on the property doc!
Mats, I've tested using three samples from https://developer.mozilla.org/en-US/docs/Web/CSS/box-decoration-break using Firefox 32 beta 8 and latest Aurora (20140819004001) under Win 7 64-bit, Ubuntu 13.04 32-bit and Mac OSX 10.9.4. Everything looks good except for the box-decoration-break-inline-extreme under Mac, where the characters are exceeding the circles. Please see http://i.imgur.com/O4IbnFa.png. Is this related to this issue? Thanks
(In reply to Petruta Rasa [QA] [:petruta] from comment #24) > Everything looks good except for the box-decoration-break-inline-extreme > under Mac, where the characters are exceeding the circles. Please see > http://i.imgur.com/O4IbnFa.png. Yeah, I think that can happen with extreme border-radius values. I guess we can avoid that and make it look better by adding some padding, say padding:10px. Feel free to update the example and add a new screenshot on the wiki-page ;-)
Adding padding:5px makes it look better on Mac too, thanks. Marking as verified as per comment 24.
You need to log in before you can comment on or make changes to this bug.